You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Stefan Bodewig <bo...@apache.org> on 2004/03/02 09:30:30 UTC

[VFS][PATCH] make it compile

Hi,

as you've seen in the nag messages, vfs currently doesn't compile
because of some bad package names in two import statements.  The
appended trivial patch fixes it.

Cheers

        Stefan

-- 
http://stefanbodewig.blogger.de/

Index: src/java/org/apache/commons/vfs/provider/webdav/WebDavFileSystem.java
===================================================================
RCS file: /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apache/commons/vfs/provider/webdav/WebDavFileSystem.java,v
retrieving revision 1.9
diff -u -r1.9 WebDavFileSystem.java
--- src/java/org/apache/commons/vfs/provider/webdav/WebDavFileSystem.java	28 Feb 2004 03:35:52 -0000	1.9
+++ src/java/org/apache/commons/vfs/provider/webdav/WebDavFileSystem.java	2 Mar 2004 08:28:02 -0000
@@ -18,6 +18,7 @@
 import java.io.IOException;
 import java.util.Collection;
 import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpURL;
 import org.apache.commons.vfs.Capability;
 import org.apache.commons.vfs.FileName;
 import org.apache.commons.vfs.FileObject;
@@ -25,7 +26,6 @@
 import org.apache.commons.vfs.FileSystemException;
 import org.apache.commons.vfs.provider.AbstractFileSystem;
 import org.apache.commons.vfs.provider.GenericFileName;
-import org.apache.util.HttpURL;
 import org.apache.webdav.lib.WebdavResource;
 
 /**
Index: src/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java
===================================================================
RCS file: /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java,v
retrieving revision 1.11
diff -u -r1.11 WebdavFileObject.java
--- src/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java	28 Feb 2004 03:35:52 -0000	1.11
+++ src/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java	2 Mar 2004 08:28:02 -0000
@@ -22,13 +22,13 @@
 import java.util.Enumeration;
 import java.util.HashMap;
 import java.util.Map;
+import org.apache.commons.httpclient.HttpURL;
 import org.apache.commons.vfs.FileObject;
 import org.apache.commons.vfs.FileSystemException;
 import org.apache.commons.vfs.FileType;
 import org.apache.commons.vfs.provider.AbstractFileObject;
 import org.apache.commons.vfs.provider.GenericFileName;
 import org.apache.commons.vfs.util.MonitorOutputStream;
-import org.apache.util.HttpURL;
 import org.apache.webdav.lib.BaseProperty;
 import org.apache.webdav.lib.WebdavResource;
 import org.apache.webdav.lib.methods.DepthSupport;

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [SANDBOX] policy question

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 2 Mar 2004, Henri Yandell <ba...@generationjava.com> wrote:

> I don't bother to add to the status file as I consider this kind of
> thing to be Commons development and not VFS specific stuff.

OK, thanks to you three.  I've committed the patch.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [SANDBOX] policy question (was Re: [VFS][PATCH] make it compile)

Posted by Tim O'Brien <to...@discursive.com>.
On Tue, 2 Mar 2004, Henri Yandell wrote:
> I don't bother to add to the status file as I consider this kind of thing
> to be Commons development and not VFS specific stuff.
> 
> It's a bit rude of me, but no one has complained at me yet for barging
> into their project to fix some typo or move docs around.

I don't consider that rude at all - I consider that right.

Too much "turf" in the Commons - I think this is the main reason why 
projects stagnate.  People assume that "somebody else" is taking care of 
project X - I've found that they usually are not.

If there is a project with shotty documentation or typos, the expectation
should be that it can be fixed by *anyone* with commit rights.  Broken
windows should be fixed by whomever has the itch and the karma, if another
committer doesn't like a change then -1 it. 





---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [SANDBOX] policy question (was Re: [VFS][PATCH] make it compile)

Posted by Henri Yandell <ba...@generationjava.com>.
I don't bother to add to the status file as I consider this kind of thing
to be Commons development and not VFS specific stuff.

It's a bit rude of me, but no one has complained at me yet for barging
into their project to fix some typo or move docs around.

Hen

On Tue, 2 Mar 2004, matthew.hawthorne wrote:

> Stefan Bodewig wrote:
> > since I have karma for the sandbox, I could easily apply the patch
> > myself.  On the other hand I do not plan to get involved with VFS
> > beyond making it compile right now, so it feel wrong to add myself to
> > the status file and commit away.
> >
> > Should I commit it without adding myself to the status file or should
> > I simply wait until the patch gets applied by one of the people listed
> > there?
>
>
> I say go ahead and commit.  Since this is a unique situation, adding
> yourself to the status file is probably still good practice, but not a
> necessity.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [SANDBOX] policy question (was Re: [VFS][PATCH] make it compile)

Posted by "matthew.hawthorne" <ma...@apache.org>.
Stefan Bodewig wrote:
> since I have karma for the sandbox, I could easily apply the patch
> myself.  On the other hand I do not plan to get involved with VFS
> beyond making it compile right now, so it feel wrong to add myself to
> the status file and commit away.
> 
> Should I commit it without adding myself to the status file or should
> I simply wait until the patch gets applied by one of the people listed
> there?


I say go ahead and commit.  Since this is a unique situation, adding
yourself to the status file is probably still good practice, but not a 
necessity.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[SANDBOX] policy question (was Re: [VFS][PATCH] make it compile)

Posted by Stefan Bodewig <bo...@apache.org>.
Hi all,

since I have karma for the sandbox, I could easily apply the patch
myself.  On the other hand I do not plan to get involved with VFS
beyond making it compile right now, so it feel wrong to add myself to
the status file and commit away.

Should I commit it without adding myself to the status file or should
I simply wait until the patch gets applied by one of the people listed
there?

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org