[jira] [Commented] (AMBARI-11202) templeton.hive.properties property value substitution should be done by ambari-server

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-11202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550826#comment-14550826 ] 

Hadoop QA commented on AMBARI-11202:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12733836/AMBARI-11202_02.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-server.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/2775//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/2775//console

This message is automatically generated.

> templeton.hive.properties property value substitution should be done by ambari-server
> -------------------------------------------------------------------------------------
>
>                 Key: AMBARI-11202
>                 URL: https://issues.apache.org/jira/browse/AMBARI-11202
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.1.0
>            Reporter: Robert Levas
>            Assignee: Robert Levas
>            Priority: Critical
>              Labels: kerberos, kerberos_descriptor
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-11202_01.patch, AMBARI-11202_02.patch
>
>
> The webhcat-site/templeton.hive.properties property value substitution should be done by ambari-server.  This value is more complicated than others since the (embedded) hive.metastore.uris property is a list of thrift URIs generated using the set of hosts the Hive Metastore is installed on.  This list of hosts comes from the clusterHostInfo/hive_metastore_host value, which in the KerberosHelper (org.apache.ambari.server.controller.KerberosHelper) is available as a comma-delimited list of hosts.
> {code}
> clusterHostInfo/hive_metastore_host = "host1,host2,host3"
> {code}
> To generate configuration values when enabling Kerberos, the KerberosHelper class uses org.apache.ambari.server.state.kerberos.AbstractKerberosDescriptor#replaceVariables to replace variables specified in the Kerberos Descriptor.  Currently this mechanism uses a simple replacement scheme, which is not sufficient to generate string using a delimited list of values. 
> In order to solve this issue, "functions" need to be applied to replacement data before making the substitution.  In this case a "function" named "each" will be created that takes the following arguments:
> * pattern with placeholders
> * delimiter to use to concatenate values generated using the patter
> * regex to use to split the original string
> For example: 
> {code:title=function declaration, commas are escaped when not intended to separate function args}
> each(thrift://%s:9083, \\,, \s*\,\s*)
> {code}
> To indicate this function is to be used, the following Kerberos Descriptor variable replacement syntax is to be used:
> {code}
> ${clusterHostInfo/hive_metastore_host|each(thrift://%s:9083, \\,, \s*\,\s*)}
> {code}
> Note: \ characters need to be escaped in JSON structure values.  For example: 
> {code}
> "some.property" : "${clusterHostInfo/hive_metastore_host|each(thrift://%s:9083, \\\\,, \\s*\\,\\s*)}"
> {code}
> If clusterHostInfo/hive_metastore_host = "host1,host2,host3", the result would be 
> {code}
> thrift://host1:9083\,thrift://host2:9083\,thrift://host3:9083
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)