[GitHub] [beam] lukecwik commented on a change in pull request #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator.

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator.
URL: https://github.com/apache/beam/pull/11224#discussion_r398695607
 
 

 ##########
 File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/PipelineValidator.java
 ##########
 @@ -221,23 +229,39 @@ private static void validateParDo(String id, PTransform transform, Components co
           id,
           sideInputId);
     }
-    // TODO: Validate state_specs and timer_specs
+    if (payload.getStateSpecsCount() > 0 || payload.getTimerSpecsCount() > 0) {
 
 Review comment:
   This should also have timer family specs.
   
   @boyuanzz Once this code is merged, this is another place where TimerSpecs will need to be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services