You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/04/03 04:49:36 UTC

Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Repository: aurora


Description
-------

Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
  src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
  src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
  src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
  src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
  src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 

Diff: https://reviews.apache.org/r/32806/diff/


Testing
-------

Test suite + end-to-end tests.


Thanks,

Bill Farner


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/#review78758
-----------------------------------------------------------


Master (a7b95d9) is red with this patch.
  ./build-support/jenkins/build.sh

:api:classesThriftNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java:327: 'if' child have incorrect indentation level 9, expected level should be 8.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 1 mins 34.926 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 3, 2015, 2:49 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32806/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 2:49 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
>   src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
>   src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 
> 
> Diff: https://reviews.apache.org/r/32806/diff/
> 
> 
> Testing
> -------
> 
> Test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/
-----------------------------------------------------------

(Updated April 9, 2015, 4:45 a.m.)


Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Repository: aurora


Description
-------

Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
  src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
  src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
  src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
  src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
  src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 45a23fdc58ca7475a805c549463e87ddaa915e74 

Diff: https://reviews.apache.org/r/32806/diff/


Testing
-------

Test suite + end-to-end tests.


Thanks,

Bill Farner


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Bill Farner <wf...@apache.org>.

> On April 3, 2015, 5:15 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line 338
> > <https://reviews.apache.org/r/32806/diff/2/?file=914533#file914533line338>
> >
> >     I know this is mirroring the existing behavior but this seems like an unnecessary configuration burden - why not just use the local IP address if we're unable to reverse-lookup the hostname in DNS (and while we're at it why do we publish a DNS name to ZK instead of the server IP address)?

Happy to have that conversation on a ticket, but i don't think a refactor is the right place to make that kind of policy change.


> On April 3, 2015, 5:15 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/http/HttpService.java, line 21
> > <https://reviews.apache.org/r/32806/diff/2/?file=914532#file914532line21>
> >
> >     This seems like it's a Qualifier for HostAndPort rather than an interface. As an interface this appears to fall into the pseudo-typedef antipattern: http://www.ibm.com/developerworks/library/j-jtp02216/.

I could drop this for `Provider<HostAndPort>` to a similar end, but i find back-tracking to concrete implementations significantly harder when bindings are made against vague interfaces.  Can you see a path forward that doesn't make it difficult to map from consumer to implementer?


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/#review78795
-----------------------------------------------------------


On April 3, 2015, 3:06 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32806/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 3:06 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
>   src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
>   src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 
> 
> Diff: https://reviews.apache.org/r/32806/diff/
> 
> 
> Testing
> -------
> 
> Test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Bill Farner <wf...@apache.org>.

> On April 3, 2015, 5:15 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/http/HttpService.java, line 21
> > <https://reviews.apache.org/r/32806/diff/2/?file=914532#file914532line21>
> >
> >     This seems like it's a Qualifier for HostAndPort rather than an interface. As an interface this appears to fall into the pseudo-typedef antipattern: http://www.ibm.com/developerworks/library/j-jtp02216/.
> 
> Bill Farner wrote:
>     I could drop this for `Provider<HostAndPort>` to a similar end, but i find back-tracking to concrete implementations significantly harder when bindings are made against vague interfaces.  Can you see a path forward that doesn't make it difficult to map from consumer to implementer?
> 
> Kevin Sweeney wrote:
>     I don't find the path for Qualifier implementaitons hard to find
>     
>     Injection sites will typically have
>     
>     ```java
>     @Inject
>     InjectionSite(@Http HostAndPort httpHostAndPort) {
>     }
>     ```
>     
>     Find Usages on Http will lead to a section "usages in .class" which will lead to something like
>     
>     ```java
>     class ConfigModule extends AbstractModule {
>        @Override
>        protected void configure() {
>          bind(HostAndPort.class).annotatedWith(Http.class).toInstance(HostAndPort.createFrom("127.0.0.1:80"));
>        }
>     }
>     ```
>     
>     or a section Annotation that will lead to
>     
>     ```java
>     class ConfigModule extends AbstractModule {
>       @Override protected void configure() {}
>     
>       @Provides
>       @Http
>       HostAndPort provideHttpHostAndPort() {
>         //...
>       }
>     }
>     ```
>     
>     and the declaration of the qualifier itself has information about what makes the thing special in its javadoc
>     
>     ```java
>     /**
>      * The main HTTP port.
>      */
>     @Qualifier
>     @Retention(RUNTIME)
>     @Target({FIELD, METHOD, PARAMETER})
>     @Documented
>     public @interface Http {}
>     ```

Right, i'm familiar with the moving parts involved.  One detail not addressed in your comment above is that this must be a `Provider`, since the port number is not known during binding (it could be an ephemeral port, and `== 0` at binding time).  IMHO this is the point where implementing `Provider` in `HttpServerLauncher` and introducing a binding annotation seemed worse than the custom interface.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/#review78795
-----------------------------------------------------------


On April 3, 2015, 3:06 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32806/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 3:06 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
>   src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
>   src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 
> 
> Diff: https://reviews.apache.org/r/32806/diff/
> 
> 
> Testing
> -------
> 
> Test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Kevin Sweeney <ke...@apache.org>.

> On April 3, 2015, 10:15 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line 338
> > <https://reviews.apache.org/r/32806/diff/2/?file=914533#file914533line338>
> >
> >     I know this is mirroring the existing behavior but this seems like an unnecessary configuration burden - why not just use the local IP address if we're unable to reverse-lookup the hostname in DNS (and while we're at it why do we publish a DNS name to ZK instead of the server IP address)?
> 
> Bill Farner wrote:
>     Happy to have that conversation on a ticket, but i don't think a refactor is the right place to make that kind of policy change.

Good idea, filed https://issues.apache.org/jira/browse/AURORA-1245


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/#review78795
-----------------------------------------------------------


On April 2, 2015, 8:06 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32806/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 8:06 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
>   src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
>   src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 
> 
> Diff: https://reviews.apache.org/r/32806/diff/
> 
> 
> Testing
> -------
> 
> Test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Kevin Sweeney <ke...@apache.org>.

> On April 3, 2015, 10:15 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/http/HttpService.java, line 21
> > <https://reviews.apache.org/r/32806/diff/2/?file=914532#file914532line21>
> >
> >     This seems like it's a Qualifier for HostAndPort rather than an interface. As an interface this appears to fall into the pseudo-typedef antipattern: http://www.ibm.com/developerworks/library/j-jtp02216/.
> 
> Bill Farner wrote:
>     I could drop this for `Provider<HostAndPort>` to a similar end, but i find back-tracking to concrete implementations significantly harder when bindings are made against vague interfaces.  Can you see a path forward that doesn't make it difficult to map from consumer to implementer?

I don't find the path for Qualifier implementaitons hard to find

Injection sites will typically have

```java
@Inject
InjectionSite(@Http HostAndPort httpHostAndPort) {
}
```

Find Usages on Http will lead to a section "usages in .class" which will lead to something like

```java
class ConfigModule extends AbstractModule {
   @Override
   protected void configure() {
     bind(HostAndPort.class).annotatedWith(Http.class).toInstance(HostAndPort.createFrom("127.0.0.1:80"));
   }
}
```

or a section Annotation that will lead to

```java
class ConfigModule extends AbstractModule {
  @Override protected void configure() {}

  @Provides
  @Http
  HostAndPort provideHttpHostAndPort() {
    //...
  }
}
```

and the declaration of the qualifier itself has information about what makes the thing special in its javadoc

```java
/**
 * The main HTTP port.
 */
@Qualifier
@Retention(RUNTIME)
@Target({FIELD, METHOD, PARAMETER})
@Documented
public @interface Http {}
```


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/#review78795
-----------------------------------------------------------


On April 2, 2015, 8:06 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32806/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 8:06 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
>   src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
>   src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 
> 
> Diff: https://reviews.apache.org/r/32806/diff/
> 
> 
> Testing
> -------
> 
> Test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/#review78795
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/http/HttpService.java
<https://reviews.apache.org/r/32806/#comment127817>

    This seems like it's a Qualifier for HostAndPort rather than an interface. As an interface this appears to fall into the pseudo-typedef antipattern: http://www.ibm.com/developerworks/library/j-jtp02216/.



src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
<https://reviews.apache.org/r/32806/#comment127819>

    I know this is mirroring the existing behavior but this seems like an unnecessary configuration burden - why not just use the local IP address if we're unable to reverse-lookup the hostname in DNS (and while we're at it why do we publish a DNS name to ZK instead of the server IP address)?


- Kevin Sweeney


On April 2, 2015, 8:06 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32806/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 8:06 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
>   src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
>   src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 
> 
> Diff: https://reviews.apache.org/r/32806/diff/
> 
> 
> Testing
> -------
> 
> Test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Bill Farner <wf...@apache.org>.

> On April 3, 2015, 9:13 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line 295
> > <https://reviews.apache.org/r/32806/diff/2/?file=914533#file914533line295>
> >
> >     +newline before

Done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/#review78802
-----------------------------------------------------------


On April 3, 2015, 3:06 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32806/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 3:06 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
>   src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
>   src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 
> 
> Diff: https://reviews.apache.org/r/32806/diff/
> 
> 
> Testing
> -------
> 
> Test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/#review78802
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
<https://reviews.apache.org/r/32806/#comment127835>

    +newline before


- Joshua Cohen


On April 3, 2015, 3:06 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32806/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 3:06 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
>   src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
>   src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 
> 
> Diff: https://reviews.apache.org/r/32806/diff/
> 
> 
> Testing
> -------
> 
> Test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/#review78760
-----------------------------------------------------------


Master (a7b95d9) is red with this patch.
  ./build-support/jenkins/build.sh

:check
:build
:api:assemble
:api:compileTestJava UP-TO-DATE
:api:processTestResources UP-TO-DATE
:api:testClasses UP-TO-DATE
:api:test UP-TO-DATE
:api:check UP-TO-DATE
:api:build
:buildSrc:compileJava UP-TO-DATE
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build

BUILD SUCCESSFUL

Total time: 4 mins 3.517 secs
+ export PIP_DEFAULT_TIMEOUT=60
+ PIP_DEFAULT_TIMEOUT=60
+ mkdir -p third_party
+ pip install -d third_party -r /dev/fd/63
++ grep -v mesos.native 3rdparty/python/requirements.txt
Downloading/unpacking bottle==0.11.6 (from -r /dev/fd/63 (line 1))
  Saved ./third_party/bottle-0.11.6-py2.py3-none-any.whl
Downloading/unpacking CherryPy==3.6.0 (from -r /dev/fd/63 (line 2))

pip can't proceed with requirement 'CherryPy==3.6.0 (from -r /dev/fd/63 (line 2))' due to a pre-existing build directory.
 location: /tmp/user/2395/pip_build_jenkins/CherryPy
This is likely due to a previous installation that failed.
pip is being responsible and not assuming it can delete this.
Please delete it and try again.

Storing debug log for failure in /home/jenkins/.pip/pip.log


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 3, 2015, 3:06 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32806/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 3:06 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
>   src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
>   src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 
> 
> Diff: https://reviews.apache.org/r/32806/diff/
> 
> 
> Testing
> -------
> 
> Test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/
-----------------------------------------------------------

(Updated April 3, 2015, 3:06 a.m.)


Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Repository: aurora


Description
-------

Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
  src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
  src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 50f377587ac05dbb72063ea02502e6d980148d3e 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e03009c12de5a09761c1f444c6439ef3144b0b17 
  src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java 21fd027976f75acc427c6d9265a7c7a91895d53d 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
  src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
  src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c5c5f789de6bf7693520081d0c1acc5165603242 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 

Diff: https://reviews.apache.org/r/32806/diff/


Testing
-------

Test suite + end-to-end tests.


Thanks,

Bill Farner