You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/03 03:19:43 UTC
[GitHub] [dubbo-go] xavier-niu opened a new pull request #1298: Rft: Metadata service
xavier-niu opened a new pull request #1298:
URL: https://github.com/apache/dubbo-go/pull/1298
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
- Rename package names of metadata service both for local and remote.
- Update README.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
This PR is opened after talking with @flycash. IMO, name problems should be resolved ASAP in release candidate stages.
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
Users may encounter some errors when calling `inmemory.MetadataService` or `remote.MetadataService`, dubbo-go should be updated to the latest version to address that problem.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1298: Rft: Metadata service
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1298:
URL: https://github.com/apache/dubbo-go/pull/1298#issuecomment-873484083
@flycash I think there are not so many people using this package now. It's a good time for us to change the package name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] flycash commented on pull request #1298: Rft: Metadata service
Posted by GitBox <gi...@apache.org>.
flycash commented on pull request #1298:
URL: https://github.com/apache/dubbo-go/pull/1298#issuecomment-873415502
I am not sure if this is a good idea because those package has been exposed to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on pull request #1298: Rft: Metadata service
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on pull request #1298:
URL: https://github.com/apache/dubbo-go/pull/1298#issuecomment-873417224
> I am not sure if this is a good idea because those package has been exposed to users.
In fact, the remote.RemoteMetedataService was renamed in the RC2. I think the package name should be changed ASAP if the name could be determined and be immutable in the future, it could help the people who are new to dubbo-go know the components quickly.
If the compatibility with older systems is one of the important things, I think `inmemory` package could be reserved and marked as deprecated in the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu edited a comment on pull request #1298: Rft: Metadata service
Posted by GitBox <gi...@apache.org>.
xavier-niu edited a comment on pull request #1298:
URL: https://github.com/apache/dubbo-go/pull/1298#issuecomment-873417224
> I am not sure if this is a good idea because those package has been exposed to users.
In fact, the remote.RemoteMetedataService was renamed in the RC2. I think the package name should be changed ASAP if the name could be determined cautiously and be immutable in the future, it could help the people who are new to dubbo-go know the components quickly.
If the compatibility with older systems is one of the important things, I think `inmemory` package could be reserved and marked as deprecated in the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1298: Rft: Metadata service
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1298:
URL: https://github.com/apache/dubbo-go/pull/1298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] flycash commented on pull request #1298: Rft: Metadata service
Posted by GitBox <gi...@apache.org>.
flycash commented on pull request #1298:
URL: https://github.com/apache/dubbo-go/pull/1298#issuecomment-873417739
I understand your concern. So I say I am not sure if it's a good idea. @AlexStocks @zouyx what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1298: Rft: Metadata service
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1298:
URL: https://github.com/apache/dubbo-go/pull/1298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu edited a comment on pull request #1298: Rft: Metadata service
Posted by GitBox <gi...@apache.org>.
xavier-niu edited a comment on pull request #1298:
URL: https://github.com/apache/dubbo-go/pull/1298#issuecomment-873417224
> I am not sure if this is a good idea because those package has been exposed to users.
In fact, the `remote.RemoteMetedataService` was renamed in the RC2. I think the package name should be changed ASAP if the name could be determined cautiously and be immutable in the future, it could help the people who are new to dubbo-go know the components quickly.
If the compatibility with older systems is one of the important things, I think `inmemory` package could be reserved and marked as deprecated in the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org