[GitHub] [trafficserver] bryancall commented on a change in pull request #8722: Adds user-agent to OCSP requests

[GitBox <gi...@apache.org>]

bryancall commented on a change in pull request #8722:
URL: https://github.com/apache/trafficserver/pull/8722#discussion_r828480898



##########
File path: iocore/net/OCSPStapling.cc
##########
@@ -72,14 +73,18 @@ certinfo_map_free(void * /*parent*/, void *ptr, CRYPTO_EX_DATA * /*ad*/, int /*i
   }
 
   for (certinfo_map::iterator iter = map->begin(); iter != map->end(); ++iter) {
-    if (iter->second->uri) {
-      OPENSSL_free(iter->second->uri);
+    certinfo *cinf = iter->second;
+    if (cinf->uri) {
+      OPENSSL_free(cinf->uri);
     }
-    if (iter->second->certname) {
-      ats_free(iter->second->certname);
+    if (cinf->certname) {

Review comment:
       ats_free() already checks for nullptr




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org