You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org> on 2005/11/19 00:41:41 UTC

[jira] Created: (MYFACES-847) NPE w/ UpdateActionListener when @property is Serializable

NPE w/ UpdateActionListener when @property is Serializable
----------------------------------------------------------

         Key: MYFACES-847
         URL: http://issues.apache.org/jira/browse/MYFACES-847
     Project: MyFaces
        Type: Bug
  Components: Tomahawk  
    Versions: 1.1.1    
    Reporter: Dennis Byrne
    Priority: Minor


If the property attribute of t:updateActionListener evaluates to a property in a backing bean that is of type Serializable, the call to context.getApplication().createConverter in UpdateActionListener.processAction() returns null.  This results in a NPE at the bottom of processAction() .  Patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (MYFACES-847) NPE w/ UpdateActionListener when @property is Serializable

Posted by Mike Kienenberger <mk...@gmail.com>.
Hey Dennis,

I can certainly close this, but it sounds like you've found a valid
bug.   I've never used UpdateActionListener, so I can't be sure.  
>From what I can tell, your patch doesn't seem to fix it, though.  It
merely ignores the symptom.

If nothing else, we should be throwing better errors rather than
having an NPE someplace.

On 12/15/05, Dennis Byrne (JIRA) <de...@myfaces.apache.org> wrote:
>     [ http://issues.apache.org/jira/browse/MYFACES-847?page=comments#action_12360555 ]
>
> Dennis Byrne commented on MYFACES-847:
> --------------------------------------
>
> Someone may want to close this, as the exception can be avoided by configuring a Converter.
>
> > NPE w/ UpdateActionListener when @property is Serializable
> > ----------------------------------------------------------
> >
> >          Key: MYFACES-847
> >          URL: http://issues.apache.org/jira/browse/MYFACES-847
> >      Project: MyFaces
> >         Type: Bug
> >   Components: Tomahawk
> >     Versions: 1.1.1
> >     Reporter: Dennis Byrne
> >     Priority: Minor
> >  Attachments: myfaces.nov.18.2005.txt
> >
> > If the property attribute of t:updateActionListener evaluates to a property in a backing bean that is of type Serializable, the call to context.getApplication().createConverter in UpdateActionListener.processAction() returns null.  This results in a NPE at the bottom of processAction() .  Patch attached.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
>
>

[jira] Commented: (MYFACES-847) NPE w/ UpdateActionListener when @property is Serializable

Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-847?page=comments#action_12360555 ] 

Dennis Byrne commented on MYFACES-847:
--------------------------------------

Someone may want to close this, as the exception can be avoided by configuring a Converter.

> NPE w/ UpdateActionListener when @property is Serializable
> ----------------------------------------------------------
>
>          Key: MYFACES-847
>          URL: http://issues.apache.org/jira/browse/MYFACES-847
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.1
>     Reporter: Dennis Byrne
>     Priority: Minor
>  Attachments: myfaces.nov.18.2005.txt
>
> If the property attribute of t:updateActionListener evaluates to a property in a backing bean that is of type Serializable, the call to context.getApplication().createConverter in UpdateActionListener.processAction() returns null.  This results in a NPE at the bottom of processAction() .  Patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (MYFACES-847) NPE w/ UpdateActionListener when @property is Serializable

Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-847?page=all ]
     
Mike Kienenberger closed MYFACES-847:
-------------------------------------

    Fix Version: Nightly
     Resolution: Fixed

Fixed.   Thanks.

I didn't understand why you had the converter check in a finally block, so I removed the finally bock and put it in front of the converter method call.

> NPE w/ UpdateActionListener when @property is Serializable
> ----------------------------------------------------------
>
>          Key: MYFACES-847
>          URL: http://issues.apache.org/jira/browse/MYFACES-847
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.1
>     Reporter: Dennis Byrne
>     Assignee: Mike Kienenberger
>     Priority: Minor
>      Fix For: Nightly
>  Attachments: myfaces.nov.18.2005.txt, wrappedNPE.txt
>
> If the property attribute of t:updateActionListener evaluates to a property in a backing bean that is of type Serializable, the call to context.getApplication().createConverter in UpdateActionListener.processAction() returns null.  This results in a NPE at the bottom of processAction() .  Patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MYFACES-847) NPE w/ UpdateActionListener when @property is Serializable

Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-847?page=all ]

Dennis Byrne updated MYFACES-847:
---------------------------------

    Attachment: wrappedNPE.txt

... wrapped NPE.

> NPE w/ UpdateActionListener when @property is Serializable
> ----------------------------------------------------------
>
>          Key: MYFACES-847
>          URL: http://issues.apache.org/jira/browse/MYFACES-847
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.1
>     Reporter: Dennis Byrne
>     Priority: Minor
>  Attachments: myfaces.nov.18.2005.txt, wrappedNPE.txt
>
> If the property attribute of t:updateActionListener evaluates to a property in a backing bean that is of type Serializable, the call to context.getApplication().createConverter in UpdateActionListener.processAction() returns null.  This results in a NPE at the bottom of processAction() .  Patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MYFACES-847) NPE w/ UpdateActionListener when @property is Serializable

Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-847?page=all ]

Dennis Byrne updated MYFACES-847:
---------------------------------

    Attachment: myfaces.nov.18.2005.txt

> NPE w/ UpdateActionListener when @property is Serializable
> ----------------------------------------------------------
>
>          Key: MYFACES-847
>          URL: http://issues.apache.org/jira/browse/MYFACES-847
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.1
>     Reporter: Dennis Byrne
>     Priority: Minor
>  Attachments: myfaces.nov.18.2005.txt
>
> If the property attribute of t:updateActionListener evaluates to a property in a backing bean that is of type Serializable, the call to context.getApplication().createConverter in UpdateActionListener.processAction() returns null.  This results in a NPE at the bottom of processAction() .  Patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira