You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/05/05 20:45:47 UTC

[GitHub] [fluo] andrewhabib opened a new pull request #1092: Javadoc mistake in byteAt(int)

andrewhabib opened a new pull request #1092:
URL: https://github.com/apache/fluo/pull/1092


   Fix documentation of type of exception thrown by byteAt.
   
   The documentation states IllegalArgumentException is thrown if index is out of bound, while the thrown exception is IndexOutOfBoundsException.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fluo] ctubbsii commented on pull request #1092: Javadoc mistake in byteAt(int)

Posted by GitBox <gi...@apache.org>.

ctubbsii commented on pull request #1092:
URL: https://github.com/apache/fluo/pull/1092#issuecomment-624469506


   TransactorIT.testTransactorAndCache keeps failing on Travis CI, but that is clearly unrelated to this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fluo] andrewhabib commented on pull request #1092: Javadoc mistake in byteAt(int)

Posted by GitBox <gi...@apache.org>.

andrewhabib commented on pull request #1092:
URL: https://github.com/apache/fluo/pull/1092#issuecomment-624484247


   Weird!
   Probably some other code change is breaking it. 
   I hope it gets fixed soon. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fluo] ctubbsii commented on pull request #1092: Javadoc mistake in byteAt(int)

Posted by GitBox <gi...@apache.org>.

ctubbsii commented on pull request #1092:
URL: https://github.com/apache/fluo/pull/1092#issuecomment-624492111


   Thanks for the PR @andrewhabib . If you wish to be added as a contributor to https://fluo.apache.org/people/ , please open a pull request to add yourself at https://github.com/apache/fluo-website/edit/gh-pages/pages/people.md and leave a reference to `apache/fluo#1092` in your commit log.
   
   Fluo also tweets about first-time contributors. If you'd like us to do this for you, please mention your twitter handle here.
   
   If you intend to be a regular contributor to Fluo projects, please consider subscribing to our developer mailing list (https://fluo.apache.org/contactus/) and introducing yourself. :smiley_cat:


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org