You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/12/12 05:16:35 UTC
[kudu-CR] [client] small cleanup on AsyncRandomTxnManagerRpc
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16867
Change subject: [client] small cleanup on AsyncRandomTxnManagerRpc
......................................................................
[client] small cleanup on AsyncRandomTxnManagerRpc
This patch changes AsyncRandomTxnManagerRpc so it owns the request
protobuf message. The rationale: there is no need to keep a pointer
because the request message is no longer needed at the call sites
once it's populated and passed to the AsyncRandomTxnManagerRpc's
constructor. I also modified the call sites accordingly to use
move semantics for the corresponding argument while calling the
constructor.
This patch does not contain any functional changes.
Change-Id: Ide5b96644832bbcd2c3b08e72aee49f993ddb95f
---
M src/kudu/client/transaction-internal.cc
M src/kudu/client/txn_manager_proxy_rpc.cc
M src/kudu/client/txn_manager_proxy_rpc.h
3 files changed, 70 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/16867/1
--
To view, visit http://gerrit.cloudera.org:8080/16867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide5b96644832bbcd2c3b08e72aee49f993ddb95f
Gerrit-Change-Number: 16867
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client] small cleanup on AsyncRandomTxnManagerRpc
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16867 )
Change subject: [client] small cleanup on AsyncRandomTxnManagerRpc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide5b96644832bbcd2c3b08e72aee49f993ddb95f
Gerrit-Change-Number: 16867
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 15 Dec 2020 01:48:41 +0000
Gerrit-HasComments: No
[kudu-CR] [client] small cleanup on AsyncRandomTxnManagerRpc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16867 )
Change subject: [client] small cleanup on AsyncRandomTxnManagerRpc
......................................................................
[client] small cleanup on AsyncRandomTxnManagerRpc
This patch changes AsyncRandomTxnManagerRpc so it owns the request
protobuf message. The rationale: there is no need to keep a pointer
because the request message is no longer needed at the call sites
once it's populated and passed to the AsyncRandomTxnManagerRpc's
constructor. I also modified the call sites accordingly to use
move semantics for the corresponding argument while calling the
constructor.
This patch does not contain any functional changes.
Change-Id: Ide5b96644832bbcd2c3b08e72aee49f993ddb95f
Reviewed-on: http://gerrit.cloudera.org:8080/16867
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/client/transaction-internal.cc
M src/kudu/client/txn_manager_proxy_rpc.cc
M src/kudu/client/txn_manager_proxy_rpc.h
3 files changed, 70 insertions(+), 62 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide5b96644832bbcd2c3b08e72aee49f993ddb95f
Gerrit-Change-Number: 16867
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)