You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "c-thiel (via GitHub)" <gi...@apache.org> on 2026/09/14 11:06:01 UTC
[PR] OpenAPI: Add missing type: object to AssertViewUUID [iceberg]
c-thiel opened a new pull request, #18099:
URL: https://github.com/apache/iceberg/pull/18099
AssertViewUUID is the only schema the ViewRequirement discriminator maps to, but it does not say it is an object. OpenAPI requires a discriminator target to be an object schema or an allOf, so tools cannot tell what this schema is.
This looks like a leftover from #11955.
The wire format and the meaning of the schema do not change, and the generated Python code is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add missing type: object to AssertViewUUID [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18099:
URL: https://github.com/apache/iceberg/pull/18099#issuecomment-6227295947
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add missing type: object to AssertViewUUID [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #18099:
URL: https://github.com/apache/iceberg/pull/18099#discussion_r4027163837
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3823,6 +3823,7 @@ components:
- $ref: '#/components/schemas/AssertViewUUID'
AssertViewUUID:
+ type: object
Review Comment:
what about other Assert* definitions like `AssertTableUUID` or `AssertRefSnapshotId`? Or does `AssertViewUUID` actually need
```
allOf:
- $ref: '#/components/schemas/ViewRequirement'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add missing type: object to AssertViewUUID [iceberg]
Posted by "c-thiel (via GitHub)" <gi...@apache.org>.
c-thiel commented on code in PR #18099:
URL: https://github.com/apache/iceberg/pull/18099#discussion_r4027753103
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3823,6 +3823,7 @@ components:
- $ref: '#/components/schemas/AssertViewUUID'
AssertViewUUID:
+ type: object
Review Comment:
Thanks for taking a look!
`AssertTableUUID`, `AssertRefSnapshotId` etc. don't need it. They all have `allOf: [$ref TableRequirement]`, and `TableRequirement` is `type: object`, so they inherit it. `AssertViewUUID` can't inherit anything because `ViewRequirement` is a `oneOf` union rather than a base class. Other `oneOf` members in this spec (`EmptyPlanningResult`, `AsyncPlanningResult`) declare `type: object` themselves, so this follows the existing convention. `AssertViewUUID` was the only discriminator target with neither `allOf` nor `type: object`.
`allOf: [$ref ViewRequirement]` would create a cycle, since `ViewRequirement` already has `oneOf: [$ref AssertViewUUID]`. If you do that you will see generation failing with `maximum recursion depth exceeded`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add missing type: object to AssertViewUUID [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #18099:
URL: https://github.com/apache/iceberg/pull/18099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org