You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2011/11/29 05:09:39 UTC
[jira] [Created] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Tests should use *Driver.new*Driver factory methods for cleaner code
--------------------------------------------------------------------
Key: MRUNIT-46
URL: https://issues.apache.org/jira/browse/MRUNIT-46
Project: MRUnit
Issue Type: Improvement
Reporter: Brock Noland
Priority: Minor
Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Jim Donofrio (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio updated MRUNIT-46:
-------------------------------
Attachment: MRUNIT-46-2.patch
Ok that looks good except somehow the patch did not include changing to the shortcut method in the testConfiguration method in the mapreduce.MapDriver and ReduceDriver classes. This patch includes just those changes, maybe it was a svn conflict with one of my other patches?
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Jim Donofrio
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-46-2.patch, MRUNIT-46.patch
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Jim Donofrio (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio reopened MRUNIT-46:
--------------------------------
see comment above with new patch MRUNIT-46-2.patch
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Jim Donofrio
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-46-2.patch, MRUNIT-46.patch
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Jim Donofrio (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio resolved MRUNIT-46.
--------------------------------
Resolution: Fixed
last commit in above post by Brock fixed 2 missing changes
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Jim Donofrio
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-46-2.patch, MRUNIT-46.patch
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated MRUNIT-46:
-------------------------------
Fix Version/s: (was: 0.8.0)
1.0.0
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Brock Noland (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216669#comment-13216669 ]
Brock Noland commented on MRUNIT-46:
------------------------------------
Jim,
Excellent work! The only comment I have is the method added to o.a.h.mrunit.MapReduceDriver should also be added to o.a.h.mrunit.mapreduce.MapReduceDriver.
Thoughts?
Brock
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-46.patch
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Brock Noland (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216778#comment-13216778 ]
Brock Noland commented on MRUNIT-46:
------------------------------------
You are correct sir! I will blame it on being tired. I created MRUNIT-67 to address this. Committed in 1293860.
Thank you for your contribution!
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-46.patch
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated MRUNIT-46:
-------------------------------
Fix Version/s: 0.8.0
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 0.8.0
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Brock Noland (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland resolved MRUNIT-46.
--------------------------------
Resolution: Fixed
Assignee: Jim Donofrio
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Jim Donofrio
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-46.patch
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Brock Noland (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216795#comment-13216795 ]
Brock Noland commented on MRUNIT-46:
------------------------------------
Yeah I had to do some merging due to the other patches. Committed to trunk in 1293877. Thanks again!
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Jim Donofrio
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-46-2.patch, MRUNIT-46.patch
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Jim Donofrio (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216679#comment-13216679 ]
Jim Donofrio commented on MRUNIT-46:
------------------------------------
I would agree but the o.a.h.mrunit.mapreduce.MapReduceDriver currently has no support for combiners
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-46.patch
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
Posted by "Jim Donofrio (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio updated MRUNIT-46:
-------------------------------
Attachment: MRUNIT-46.patch
changed all constructor calls to MapDriver, ReduceDriver, and MapReduceDriver in either the mrunit or mrunit.mapreduce packages to use the shortcut newMapDriver, etc calls
updated instances of these constructor calls in the documentation to the shortcut method
added shortcut constructor method to include the combiner in the mrunit.MapReduceDriver class
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-46.patch
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira