You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2022/03/04 10:32:56 UTC

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18290


Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................

IMPALA-11154: Idle Kudu daemons consume too much CPU

Due to KUDU-1973 kudu-tservers produce high CPU consumption (see also
KUDU-3134) when there is a high number of table replicas. This means
that in the Impala dev environment the CPU consumption can be around
15-20% per kudu-tserver (there are 3 kudu-tservers) when all the Kudu
tables are loaded. Setting the value to 5 seconds lowers CPU usage to
~3% per kudu-terver.

Testing:
 * ran exhaustive tests

Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
---
M testdata/cluster/node_templates/common/etc/kudu/tserver.conf.tmpl
1 file changed, 8 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/18290/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................

IMPALA-11154: Idle Kudu daemons consume too much CPU

Due to KUDU-1973 kudu-tservers produce high CPU consumption (see also
KUDU-3134) when there is a high number of table replicas. This means
that in the Impala dev environment the CPU consumption can be around
15-20% per kudu-tserver (there are 3 kudu-tservers) when all the Kudu
tables are loaded. Setting the value to 3 seconds lowers CPU usage to
~5% per kudu-terver.

Testing:
 * ran exhaustive tests

Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Reviewed-on: http://gerrit.cloudera.org:8080/18290
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/cluster/node_templates/common/etc/kudu/tserver.conf.tmpl
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Wenzhe Zhou: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10251/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 10:52:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7905/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 17:52:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 2:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7908/


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Mar 2022 05:02:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7905/


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 23:11:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10267/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 19:22:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7914/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 20:15:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7908/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 23:26:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 3:

I think we've hit what is mentioned in the comment of KUDU-3134. I'm lowering the heartbeat interval to 3 seconds as it was recommended by a Kudu engineer.


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 19:03:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 20:14:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18290

to look at the new patch set (#3).

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................

IMPALA-11154: Idle Kudu daemons consume too much CPU

Due to KUDU-1973 kudu-tservers produce high CPU consumption (see also
KUDU-3134) when there is a high number of table replicas. This means
that in the Impala dev environment the CPU consumption can be around
15-20% per kudu-tserver (there are 3 kudu-tservers) when all the Kudu
tables are loaded. Setting the value to 3 seconds lowers CPU usage to
~5% per kudu-terver.

Testing:
 * ran exhaustive tests

Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
---
M testdata/cluster/node_templates/common/etc/kudu/tserver.conf.tmpl
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/18290/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 2:

Hit IMPALA-10999


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 23:25:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 2:

Failed in test case test_kudu.py::TestKuduBasicDML.test_kudu_insert


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 17:53:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 1: Code-Review+2

Thanks for working on this.


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 17:51:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 17:52:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11154: Idle Kudu daemons consume too much CPU

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18290 )

Change subject: IMPALA-11154: Idle Kudu daemons consume too much CPU
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4de56540f5a7dc860bf6e27d9a5c0e4f4b3d26
Gerrit-Change-Number: 18290
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Mar 2022 01:12:42 +0000
Gerrit-HasComments: No