You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2022/10/23 20:12:00 UTC

[jira] [Commented] (CALCITE-5342) Refactor SqlFunctions lastDay, addMonths, subtractMonths to use DateTimeUtils from Avatica

    [ https://issues.apache.org/jira/browse/CALCITE-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622874#comment-17622874 ] 

Julian Hyde commented on CALCITE-5342:
--------------------------------------

Please hold off on this. I am touching this code in CALCITE-5155 and CALCITE-5338.

> Refactor SqlFunctions lastDay, addMonths, subtractMonths to use DateTimeUtils from Avatica
> ------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-5342
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5342
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>
> Refactor the following [SqlFunctions|https://github.com/apache/calcite/blob/040e85a9219a65122f6ae5ecd8f988afe29e5180/core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java]:
> * lastDay;
> * addMonths;
> * subtractMonths 
> to use the respective methods from [DateTimeUtils|https://github.com/apache/calcite-avatica/blob/af0e9e44ccff4580c1560835da62e8d593181c86/core/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java] in Avatica and remove duplicate code between the repos.
> It is necessary to wait for Avatica 1.23.0 (CALCITE-5341) for doing this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)