[GitHub] merlimat commented on a change in pull request #1174: Throw ProducerBusy when producer with same name is already connected

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1174: Throw ProducerBusy when producer with same name is already connected
URL: https://github.com/apache/incubator-pulsar/pull/1174#discussion_r166093367
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -109,6 +109,8 @@ enum ServerError {
     ConsumerNotFound = 13; // Consumer not found
     TooManyRequests = 14; // Error with too many simultaneously request
     TopicTerminatedError = 15; // The topic has been terminated
+
+    ProducerBusy         = 16; // Producer with same name is already connected
 
 Review comment:
   New enum values are all deserialized as 0 which is defined as `UnknownError` and treated with the same generic `PulsarClientException`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services