You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zddr (via GitHub)" <gi...@apache.org> on 2023/03/17 10:47:03 UTC
[GitHub] [doris] zddr opened a new pull request, #17915: [Enhancement](auth)support ranger col priv
zddr opened a new pull request, #17915:
URL: https://github.com/apache/doris/pull/17915
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
1.When querying data, it is no longer necessary to verify the permissions of the entire table, but rather to verify the permissions of the queried columns. Currently, the 'ranger' already supports column permissions, and the internal catalog provides the implementation of dummy column permissions (the actual verified permissions are still table permissions)
2.delete roles in userIdentity
3.Change trigger logic of initAccessController
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #17915: [Enhancement](auth)support ranger col priv
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #17915:
URL: https://github.com/apache/doris/pull/17915#issuecomment-1473646505
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17915: [Enhancement](auth)support ranger col priv
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #17915:
URL: https://github.com/apache/doris/pull/17915#issuecomment-1473710451
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.51 seconds
stream load tsv: 473 seconds loaded 74807831229 Bytes, about 150 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230317114514_clickbench_pr_116046.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #17915: [Enhancement](auth)support ranger col priv
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #17915:
URL: https://github.com/apache/doris/pull/17915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #17915: [Enhancement](auth)support ranger col priv
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #17915:
URL: https://github.com/apache/doris/pull/17915#issuecomment-1475570027
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #17915: [Enhancement](auth)support ranger col priv
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #17915:
URL: https://github.com/apache/doris/pull/17915#discussion_r1140904368
##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Auth.java:
##########
@@ -317,6 +320,12 @@ public boolean checkTblPriv(UserIdentity currentUser, String ctl, String db, Str
public void checkColsPriv(UserIdentity currentUser, String ctl, String db, String tbl, Set<String> cols,
PrivPredicate wanted) throws AuthorizationException {
// TODO: Support column priv
+ // we check if have tbl priv,until internal support col auth.
+ if (!checkTblPriv(currentUser, ctl, db, tbl, wanted)) {
Review Comment:
Need to update the case:
`account_p0.test_nereids_authentication`
See: http://43.132.222.7:8111/buildConfiguration/Doris_DorisRegression_P0Regression/116156?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandPull+Request+Details=true&expandBuildProblemsSection=true&expandBuildTestsSection=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #17915: [Enhancement](auth)support ranger col priv
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #17915:
URL: https://github.com/apache/doris/pull/17915#issuecomment-1475107772
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17915: [Enhancement](auth)support ranger col priv
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17915:
URL: https://github.com/apache/doris/pull/17915#issuecomment-1475639741
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17915: [Enhancement](auth)support ranger col priv
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17915:
URL: https://github.com/apache/doris/pull/17915#issuecomment-1475639899
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zddr commented on pull request #17915: [Enhancement](auth)support ranger col priv
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #17915:
URL: https://github.com/apache/doris/pull/17915#issuecomment-1475114854
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org