You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/02/03 08:03:57 UTC

[GitHub] [drill] paul-rogers opened a new pull request #2451: DRILL-8124: Fix implicit column issue with EVF 2

paul-rogers opened a new pull request #2451:
URL: https://github.com/apache/drill/pull/2451


   # [DRILL-8124](https://issues.apache.org/jira/browse/DRILL-8124): Fix implicit column issue with EVF 2
   
   ## Description
   
   Fixes case in which the projection order of implicit columns changes across readers.
   
   ## Documentation
   
   N/A
   
   ## Testing
   
   Found and tested in unit tests for the Text Format reader. That work will appear in a later PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2451: DRILL-8124: Fix implicit column issue with EVF 2

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2451:
URL: https://github.com/apache/drill/pull/2451#issuecomment-1028826382


   @jnturton Not recommended, we only need to merge pull requests of repair type (as bugfix) at most. Obviously, all pull requests for the V2 series will take more time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton merged pull request #2451: DRILL-8124: Fix implicit column issue with EVF 2

Posted by GitBox <gi...@apache.org>.
jnturton merged pull request #2451:
URL: https://github.com/apache/drill/pull/2451


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2451: DRILL-8124: Fix implicit column issue with EVF 2

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2451:
URL: https://github.com/apache/drill/pull/2451#issuecomment-1028727769


   @paul-rogers Hi. Excuse me for the fact that we are voting to freeze `master` branch. In order not to miss the two pull requests you submitted today, I recommend to keep the CI passed ASAP, and I will provide a quick review. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton commented on pull request #2451: DRILL-8124: Fix implicit column issue with EVF 2

Posted by GitBox <gi...@apache.org>.
jnturton commented on pull request #2451:
URL: https://github.com/apache/drill/pull/2451#issuecomment-1028786660


   @paul-rogers, @luocooong please also consider whether this EVF v2 series of PRs should be included atomically in the current release, i.e. entirely or not at all.  If a partial inclusion that merges only a subset of the PRs from the series will bring no benefit to 1.20 users then perhaps there is wisdom in not merging any of it before 1.20?  It would also buy us time to convert all our existing EVF v1 plugins to v2 for the next release, which might be more a meaningful way for the new tech to land.
   
   Please advise me on the route we should follow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org