You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2013/09/18 23:35:53 UTC

[jira] [Resolved] (THRIFT-2191) Fix charp JSONProtocol.ReadJSONDouble (specify InvariantCulture)

     [ https://issues.apache.org/jira/browse/THRIFT-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-2191.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.9.2

Committed, thanks for spotting this bug!
                
> Fix charp JSONProtocol.ReadJSONDouble (specify InvariantCulture)
> ----------------------------------------------------------------
>
>                 Key: THRIFT-2191
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2191
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Library
>    Affects Versions: 0.9.1
>         Environment: windows 7 (localized with russian language pack)
>            Reporter: Alexander Makarov
>             Fix For: 0.9.2
>
>         Attachments: THRIFT-2191-bugfix-csharp-json-read-double.patch
>
>
> I caught error on serialization from application working under localized (Russian) Windows. Cause Double.Parse wait a system decimal separator. I fixed JSONProtocol.ReadJSONDouble method, made Double.Parse call with explicit specify InvariantCulture in second parameter.
> I think my little fix is pretty clear for you. But if it's not, I would be glad to explain more details.
> Sincerely, Alexander Makarov.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira