[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15519: [enhancement](tablet) Unify redundant `create_rowset_writer` methods

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #15519:
URL: https://github.com/apache/doris/pull/15519#discussion_r1059321507


##########
be/test/vec/olap/vertical_compaction_test.cpp:
##########
@@ -54,8 +55,6 @@ class VerticalCompactionTest : public ::testing::Test {
         }
         EXPECT_TRUE(FileUtils::create_dir(absolute_dir).ok());
         EXPECT_TRUE(FileUtils::create_dir(absolute_dir + "/tablet_path").ok());
-        _data_dir = std::make_unique<DataDir>(absolute_dir);
-        _data_dir->update_capacity();
         doris::EngineOptions options;
         k_engine = new StorageEngine(options);
         StorageEngine::_s_instance = k_engine;

Review Comment:
   warning: '_s_instance' is a private member of 'doris::StorageEngine' [clang-diagnostic-error]
   ```cpp
           StorageEngine::_s_instance = k_engine;
                          ^
   ```
   **be/src/olap/storage_engine.h:321:** declared private here
   ```cpp
   d;
                                                                    ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org