[GitHub] [spark] chia7712 commented on a change in pull request #35080: [SPARK-37792][CORE] Fix the check of custom configuration in SparkShellLoggingFilter

[GitBox <gi...@apache.org>]

chia7712 commented on a change in pull request #35080:
URL: https://github.com/apache/spark/pull/35080#discussion_r777022024



##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -257,7 +257,7 @@ private[spark] object Logging {
         var logger = LogManager.getLogger(logEvent.getLoggerName)
           .asInstanceOf[org.apache.logging.log4j.core.Logger]

Review comment:
       `org.apache.logging.log4j.core.Logger` can be replaced by `Log4jLogger`

##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -257,7 +257,7 @@ private[spark] object Logging {
         var logger = LogManager.getLogger(logEvent.getLoggerName)
           .asInstanceOf[org.apache.logging.log4j.core.Logger]
         while (logger.getParent() != null) {

Review comment:
       Does it need to check all parents? If config of "this" logger is equal to root config, it seems to me that the config of its parents are equal to root too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org