[GitHub] spark pull request #13532: [SPARK-15204][SQL] improve nullability inference ...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13532#discussion_r69388379
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
    @@ -305,4 +305,13 @@ class DatasetAggregatorSuite extends QueryTest with SharedSQLContext {
         val ds = Seq(1, 2, 3).toDS()
         checkDataset(ds.select(MapTypeBufferAgg.toColumn), 1)
       }
    +
    +  test("spark-15204 improve nullability inference for Aggregator") {
    +    val ds1 = Seq(1, 3, 2, 5).toDS()
    +    assert(ds1.select(typed.sum((i: Int) => i)).schema.head.nullable === false)
    +    val ds2 = Seq(AggData(1, "a"), AggData(2, "a")).toDS()
    +    assert(ds2.groupByKey(_.b).agg(SeqAgg.toColumn).schema(1).nullable === true)
    --- End diff --
    
    should we use `ds.select` for all tests? And we should also test String, which is flat but nullable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org