You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/19 02:31:10 UTC
[GitHub] [incubator-devlake] abeizn opened a new pull request, #3114: feat: add deployTagPattern for gitlab
abeizn opened a new pull request, #3114:
URL: https://github.com/apache/incubator-devlake/pull/3114
# Summary
feat: add deployTagPattern for gitlab
### Does this close any open issues?
related to #3101
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #3114: feat: add deployTagPattern for gitlab
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #3114:
URL: https://github.com/apache/incubator-devlake/pull/3114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3114: feat: add deployTagPattern for gitlab
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3114:
URL: https://github.com/apache/incubator-devlake/pull/3114#discussion_r973847022
##########
plugins/gitlab/tasks/task_data.go:
##########
@@ -76,6 +76,9 @@ func DecodeAndValidateTaskOptions(options map[string]interface{}) (*GitlabOption
if op.IssueTypeRequirement == "" {
op.IssueTypeRequirement = "^(feat|feature|proposal|requirement)$"
}
+ if op.DeployTagPattern == "" {
+ op.DeployTagPattern = "(?i)deploy"
Review Comment:
what about `.*deploy.*$`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3114: feat: add deployTagPattern for gitlab
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3114:
URL: https://github.com/apache/incubator-devlake/pull/3114#discussion_r973847022
##########
plugins/gitlab/tasks/task_data.go:
##########
@@ -76,6 +76,9 @@ func DecodeAndValidateTaskOptions(options map[string]interface{}) (*GitlabOption
if op.IssueTypeRequirement == "" {
op.IssueTypeRequirement = "^(feat|feature|proposal|requirement)$"
}
+ if op.DeployTagPattern == "" {
+ op.DeployTagPattern = "(?i)deploy"
Review Comment:
what about `.*deploy.*$`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3114: feat: add deployTagPattern for gitlab
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3114:
URL: https://github.com/apache/incubator-devlake/pull/3114#discussion_r973847022
##########
plugins/gitlab/tasks/task_data.go:
##########
@@ -76,6 +76,9 @@ func DecodeAndValidateTaskOptions(options map[string]interface{}) (*GitlabOption
if op.IssueTypeRequirement == "" {
op.IssueTypeRequirement = "^(feat|feature|proposal|requirement)$"
}
+ if op.DeployTagPattern == "" {
+ op.DeployTagPattern = "(?i)deploy"
Review Comment:
what about .*deploy.*$
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org