[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null

["Leon (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136879#comment-13136879 ] 

Leon commented on OFBIZ-4393:
-----------------------------

It has been able to handle null before.

According to original design (I guess), if ommit value and relFieldName attributes in condition-expr, then it will be looked as "null". Then, while the operator is "=" or "<>", the condition will be converted to "is null" and "is not null" respectively. See code pasted below:

{code:java}
            } else if ( value == null && this.relFieldName == null && (this.operator == EntityOperator.EQUALS || this.operator == EntityOperator.NOT_EQUAL)) {
                return EntityCondition.makeCondition(lhs, this.operator, null);
            } else {
{code}

But donno from which revision, the input value of absent value and relFeidlName attributes were converted to empty string (""), not "null" itself, then, now, "view entity condition-expr doesn't handle null".
                
> View entity condition-expr doesn't handle null
> ----------------------------------------------
>
>                 Key: OFBIZ-4393
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4393
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Rev 1165137
>            Reporter: Anne Jessel
>         Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira