You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/08/25 23:19:41 UTC

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7840

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................

[release-notes] KUDU-2013 is fixed in Kudu 1.5

Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
---
M docs/release_notes.adoc
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/7840/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7840/2/docs/release_notes.adoc
File docs/release_notes.adoc:

PS2, Line 34: Fixed an issue with long-lived Java clients.
> Drop this first sentence.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7840/1/docs/release_notes.adoc
File docs/release_notes.adoc:

PS1, Line 34:  the Java Kudu client
            :   did not automatically request a new authentication token after
            :   the expiration of the original one, so long-lived Java clients
            :   (over 7 days with the default server-side settings) were not supported.
> I think this may confuse some people. Rather than state the previous bug, I
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................

[release-notes] KUDU-2013 is fixed in Kudu 1.5

Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
---
M docs/release_notes.adoc
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/7840/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7840/2/docs/release_notes.adoc
File docs/release_notes.adoc:

PS2, Line 34: Fixed an issue with long-lived Java clients.
Drop this first sentence.


-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7840

to look at the new patch set (#3).

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................

[release-notes] KUDU-2013 is fixed in Kudu 1.5

Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
---
M docs/release_notes.adoc
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/7840/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................


[release-notes] KUDU-2013 is fixed in Kudu 1.5

Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Reviewed-on: http://gerrit.cloudera.org:8080/7840
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Dan Burkert <da...@apache.org>
---
M docs/release_notes.adoc
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved; Verified
  Todd Lipcon: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7840/1/docs/release_notes.adoc
File docs/release_notes.adoc:

PS1, Line 34:  the Java Kudu client
            :   did not automatically request a new authentication token after
            :   the expiration of the original one, so long-lived Java clients
            :   (over 7 days with the default server-side settings) were not supported.
I think this may confuse some people. Rather than state the previous bug, I think it is better to make a positive statement like "The Java Kudu client now automatically requests new authentication tokens after expiration. So, long-lived Java clients are now supported."


-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [release-notes] KUDU-2013 is fixed in Kudu 1.5

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
......................................................................


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No