[GitHub] [kafka] mumrah commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

["mumrah (via GitHub)" <gi...@apache.org>]

mumrah commented on code in PR #14208:
URL: https://github.com/apache/kafka/pull/14208#discussion_r1295237042


##########
metadata/src/main/java/org/apache/kafka/image/loader/LogDeltaManifest.java:
##########
@@ -66,6 +119,10 @@ public LogDeltaManifest(
         this.numBytes = numBytes;
     }
 
+    public static Builder newBuilder() {

Review Comment:
   Well, it also has a public no-arg constructor, I just like the static factory. I do like the fluent style for builders and a static method to start it off makes sense to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org