You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2022/03/16 21:17:07 UTC
[Impala-ASF-CR] IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18326
Change subject: IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
......................................................................
IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
Impala uses FLAGS_log_filename as log symlink name and as part of the
glob pattern during log rotation. The user will not set this flag in
most cases, and it will default to google::ProgramInvocationShortName().
But if the user sets a custom value to this flag, the glob pattern will
mistakenly target the symlink instead of the actual log files. This
leads to a wrong behavior of DeleteOldLogs() and
GetLatestCanonicalLogPath().
This patch replace FLAGS_log_filename with
google::ProgramInvocationShortName() in glob pattern.
Testing:
- Pass simple-logger-test
- Pass exhaustive test_breakpad.py::TestLogging
Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa
---
M be/src/common/init.cc
M be/src/common/logging.cc
M be/src/common/logging.h
M tests/custom_cluster/test_breakpad.py
4 files changed, 28 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/18326/1
--
To view, visit http://gerrit.cloudera.org:8080/18326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa
Gerrit-Change-Number: 18326
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18326 )
Change subject: IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa
Gerrit-Change-Number: 18326
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Mar 2022 19:47:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18326 )
Change subject: IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10297/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa
Gerrit-Change-Number: 18326
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Mar 2022 21:37:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18326 )
Change subject: IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
......................................................................
IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
Impala uses FLAGS_log_filename as log symlink name and as part of the
glob pattern during log rotation. The user will not set this flag in
most cases, and it will default to google::ProgramInvocationShortName().
But if the user sets a custom value to this flag, the glob pattern will
mistakenly target the symlink instead of the actual log files. This
leads to a wrong behavior of DeleteOldLogs() and
GetLatestCanonicalLogPath().
This patch replace FLAGS_log_filename with
google::ProgramInvocationShortName() in glob pattern.
Testing:
- Pass simple-logger-test
- Pass exhaustive test_breakpad.py::TestLogging
Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa
Reviewed-on: http://gerrit.cloudera.org:8080/18326
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/init.cc
M be/src/common/logging.cc
M be/src/common/logging.h
M tests/custom_cluster/test_breakpad.py
4 files changed, 28 insertions(+), 10 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa
Gerrit-Change-Number: 18326
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18326 )
Change subject: IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
......................................................................
Patch Set 1: Code-Review+2
This looks good to me. Thanks for tracking this down
--
To view, visit http://gerrit.cloudera.org:8080/18326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa
Gerrit-Change-Number: 18326
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Mar 2022 19:36:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18326 )
Change subject: IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7938/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa
Gerrit-Change-Number: 18326
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Mar 2022 19:47:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18326 )
Change subject: IMPALA-11184: Use ProgramInvocationShortName for log glob pattern
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c71bdb67f70c571d18fb8630d4a816ab75686fa
Gerrit-Change-Number: 18326
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 00:39:38 +0000
Gerrit-HasComments: No