[jira] [Commented] (TINKERPOP-2841) Test and Fix Per Request Settings in Go

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683606#comment-17683606 ] 

ASF GitHub Bot commented on TINKERPOP-2841:
-------------------------------------------

xiazcy commented on PR #1939:
URL: https://github.com/apache/tinkerpop/pull/1939#issuecomment-1414553963

   LGTM, thanks Cole! VOTE +1




> Test and Fix Per Request Settings in Go
> ---------------------------------------
>
>                 Key: TINKERPOP-2841
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2841
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: go
>    Affects Versions: 3.7.0, 3.6.1, 3.5.4
>            Reporter: Cole Greer
>            Priority: Major
>
> Gremlin go gives the option to override certain settings on a per request basis (detailed [here|https://tinkerpop.apache.org/docs/current/reference/#_per_request_settings_4]). It's been observed that when overriding the requestId, gremlin go will still make and use a new requestId instead ([here|https://github.com/apache/tinkerpop/blob/master/gremlin-go/driver/request.go#L54]). All documented per request settings need to be tested and fixed if needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)