You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2017/04/06 23:45:56 UTC
[GitHub] cordova-lib pull request #539: CB-12643 : removed references to wp8
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/539
CB-12643 : removed references to wp8
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Removed references to wp8.
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-12643
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/539.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #539
----
commit c7d8af20fcf76392061b44daad29c412a3a6d9e1
Author: Audrey So <au...@apache.org>
Date: 2017-04-06T23:12:48Z
CB-12643 : removed references to wp8
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #539: CB-12643 : removed references to wp8
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/539
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=h1) Report
> Merging [#539](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/0d637f2d67a95ef709443eaa9d7481eb14f79b8d?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 82.42% 82.58% +0.16%
==========================================
Files 68 66 -2
Lines 5462 5283 -179
Branches 1072 1051 -21
==========================================
- Hits 4502 4363 -139
+ Misses 960 920 -40
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `77.9% <�> (+0.12%)` | :arrow_up: |
| [cordova-lib/src/util/windows/csproj.js](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3V0aWwvd2luZG93cy9jc3Byb2ouanM=) | `63.73% <0%> (-2.2%)` | :arrow_down: |
| [cordova-lib/src/cordova/metadata/wp8\_parser.js](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvbWV0YWRhdGEvd3A4X3BhcnNlci5qcw==) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=footer). Last update [0d637f2...c7d8af2](https://codecov.io/gh/apache/cordova-lib/pull/539?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #539: CB-12643 : removed references to wp8
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org