You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2025/06/07 04:04:23 UTC
[PR] chore(dev/release): Update release instructions for 0.7.0 [arrow-nanoarrow]
paleolimbot opened a new pull request, #767:
URL: https://github.com/apache/arrow-nanoarrow/pull/767
Just working through these instructions to make sure everything still works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Update release instructions for 0.7.0 [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #767:
URL: https://github.com/apache/arrow-nanoarrow/pull/767#discussion_r2167210107
##########
dev/release/README.md:
##########
@@ -129,51 +102,29 @@ conda install -c conda-forge r-testthat r-hms r-blob r-pkgbuild r-bit64
Note that using conda-provided R when there is also a system install of R
on MacOS is unlikely to work.
-Linux users that have built and installed a custom build of Arrow C++ may
-have to `export LD_LIBRARY_PATH=${CONDA_PREFIX}/lib` before running the
-verification script.
-
### Windows
-On Windows, prerequisites can be installed using officially provided
-installers:
+On Windows, prerequisites can be installed using officially provided installers:
[Visual Studio](https://visualstudio.microsoft.com/vs/),
[CMake](https://cmake.org/download/), and
[Git](https://git-scm.com/downloads) should provide the prerequisties
to verify the C library; R and Rtools can be installed using the
[official R-project installer](https://cloud.r-project.org/bin/windows/).
-Arrow C++ can be built from source. The version of bash provided with
-Git for Windows can be used to execute the Arrow C++ build commands and
-the verification script.
```bash
-# Build Arrow C++ from source
-curl -L https://github.com/apache/arrow/archive/refs/tags/apache-arrow-17.0.0.tar.gz | \
- tar -zxf -
-mkdir arrow-build && cd arrow-build
-cmake ../apache-arrow-17.0.0/cpp -DCMAKE_INSTALL_PREFIX=../arrow-minimal
-cmake --build .
-cmake --install . --prefix=../arrow-minimal --config=Debug
-cd ..
-
-# Pass location of Arrow and R to the verification script
-export NANOARROW_CMAKE_OPTIONS="-DCMAKE_PREFIX_PATH=$(pwd -W)/arrow-minimal -Dgtest_force_shared_crt=ON -DNANOARROW_ARROW_STATIC=ON"
-export R_HOME="/c/Program Files/R/R-4.4.1"
+# Pass location of R to the verification script
+export NANOARROW_CMAKE_OPTIONS="-Dgtest_force_shared_crt=ON"
+export R_HOME="/c/Program Files/R/R-4.5.0"
```
+Unfortunately verifying Python via the release verification script on Windows is not currently possible, thus successful verification requites `TEST_PYTHON=0 ./verify-release-candidate.sh`.
Review Comment:
@WillAyd I think the symlinking doesn't work on Windows so I get a failure when I try to run the release script there. Let's maybe punt this one to get the release out 😮💨
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Update release instructions for 0.7.0 [arrow-nanoarrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #767:
URL: https://github.com/apache/arrow-nanoarrow/pull/767#discussion_r2188771102
##########
dev/release/README.md:
##########
@@ -538,13 +482,14 @@ The Apache Arrow Community
### Remove old artifacts from SVN
These artifacts include any release candidates that were uploaded to
-<https://dist.apache.org/repos/dist/dev/arrow/> and old releases that
-were upload to
-<https://dist.apache.org/repos/dist/release/arrow/>. You can remove
-them using:
+<https://dist.apache.org/repos/dist/dev/arrow/>. You can remove them
+using:
```
-dev/release/post-02-remove-old-artifacts.sh
+# Once
+export APACHE_USERNAME=xxx
+# Once for every release candidate
+svn rm --username=$APACHE_USERNAME -m "Clean up svn artifacts" https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-nanoarrow-0.7.0-rc0/
Review Comment:
@paleolimbot It seems this reverts changes in https://github.com/apache/arrow-nanoarrow/pull/787 . Could you remove old artifacts in https://dist.apache.org/repos/dist/release/arrow/ by `dev/release/post-02-remove-old-artifacts.sh` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Update release instructions for 0.7.0 [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #767:
URL: https://github.com/apache/arrow-nanoarrow/pull/767#discussion_r2196568288
##########
dev/release/README.md:
##########
@@ -538,13 +482,14 @@ The Apache Arrow Community
### Remove old artifacts from SVN
These artifacts include any release candidates that were uploaded to
-<https://dist.apache.org/repos/dist/dev/arrow/> and old releases that
-were upload to
-<https://dist.apache.org/repos/dist/release/arrow/>. You can remove
-them using:
+<https://dist.apache.org/repos/dist/dev/arrow/>. You can remove them
+using:
```
-dev/release/post-02-remove-old-artifacts.sh
+# Once
+export APACHE_USERNAME=xxx
+# Once for every release candidate
+svn rm --username=$APACHE_USERNAME -m "Clean up svn artifacts" https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-nanoarrow-0.7.0-rc0/
Review Comment:
So sorry! I'll remove the artifacts tomorrow 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Update release instructions for 0.7.0 [arrow-nanoarrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #767:
URL: https://github.com/apache/arrow-nanoarrow/pull/767#discussion_r2168019951
##########
dev/release/README.md:
##########
@@ -129,51 +102,29 @@ conda install -c conda-forge r-testthat r-hms r-blob r-pkgbuild r-bit64
Note that using conda-provided R when there is also a system install of R
on MacOS is unlikely to work.
-Linux users that have built and installed a custom build of Arrow C++ may
-have to `export LD_LIBRARY_PATH=${CONDA_PREFIX}/lib` before running the
-verification script.
-
### Windows
-On Windows, prerequisites can be installed using officially provided
-installers:
+On Windows, prerequisites can be installed using officially provided installers:
[Visual Studio](https://visualstudio.microsoft.com/vs/),
[CMake](https://cmake.org/download/), and
[Git](https://git-scm.com/downloads) should provide the prerequisties
to verify the C library; R and Rtools can be installed using the
[official R-project installer](https://cloud.r-project.org/bin/windows/).
-Arrow C++ can be built from source. The version of bash provided with
-Git for Windows can be used to execute the Arrow C++ build commands and
-the verification script.
```bash
-# Build Arrow C++ from source
-curl -L https://github.com/apache/arrow/archive/refs/tags/apache-arrow-17.0.0.tar.gz | \
- tar -zxf -
-mkdir arrow-build && cd arrow-build
-cmake ../apache-arrow-17.0.0/cpp -DCMAKE_INSTALL_PREFIX=../arrow-minimal
-cmake --build .
-cmake --install . --prefix=../arrow-minimal --config=Debug
-cd ..
-
-# Pass location of Arrow and R to the verification script
-export NANOARROW_CMAKE_OPTIONS="-DCMAKE_PREFIX_PATH=$(pwd -W)/arrow-minimal -Dgtest_force_shared_crt=ON -DNANOARROW_ARROW_STATIC=ON"
-export R_HOME="/c/Program Files/R/R-4.4.1"
+# Pass location of R to the verification script
+export NANOARROW_CMAKE_OPTIONS="-Dgtest_force_shared_crt=ON"
+export R_HOME="/c/Program Files/R/R-4.5.0"
```
+Unfortunately verifying Python via the release verification script on Windows is not currently possible, thus successful verification requites `TEST_PYTHON=0 ./verify-release-candidate.sh`.
Review Comment:
Ah makes sense - yea let's punt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org