[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7781: Adding Client Auth Configs to Infra Ansible

["zrhoffman (via GitHub)" <gi...@apache.org>]

zrhoffman commented on code in PR #7781:
URL: https://github.com/apache/trafficcontrol/pull/7781#discussion_r1317597246


##########
infrastructure/ansible/roles/traffic_ops/templates/cdn.conf.j2:
##########
@@ -92,5 +95,8 @@
       "convert_self_signed": {{ to_le_convert_self_signed | bool | lower }},
       "renew_days_before_expiration": {{ to_le_renew_days_before_expiration | int }},
       "environment": "{{ to_le_environment }}"
+   },
+   "client_certificate_authentication" : {
+      "root_certificates_directory" : "{{ to_client_cert_root_directory }}"

Review Comment:
   What creates `to_client_cert_root_directory`? How do we know it exists?



##########
infrastructure/ansible/roles/traffic_ops/defaults/main.yml:
##########
@@ -98,10 +98,13 @@ to_go_supported_ds_metrics:
   - tps_4xx
   - tps_5xx
 
+to_go_client_auth_enabled: 0
 to_go_whitelisted_oauth_urls: ""
 to_go_oauth_user_attribute: ""
 to_go_oauth_client_secret: ""
 
+to_client_cert_root_directory: ""

Review Comment:
   How about a more sane default for `to_client_cert_root_directory` like `"/etc/pki/tls/traffic_ops/"`?



##########
infrastructure/ansible/roles/traffic_ops/templates/cdn.conf.j2:
##########
@@ -68,6 +68,9 @@
       "plugins": {{ to_plugin_config.keys() | list | to_json }},
       "plugin_config" : {{ to_plugin_config | to_nice_json(indent=2) }},
       "traffic_vault_backend": "{{ to_traffic_vault_backend }}",
+      "tls_config": {
+         "ClientAuth": "{{ to_go_client_auth_enabled }}"
+      },

Review Comment:
   Also needs
   
   ```json
           "MinVersion": 769,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org