You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "wizardzhang (via GitHub)" <gi...@apache.org> on 2023/11/23 09:16:15 UTC
[PR] [ISSUE #3399] replace anonymous inner class with lambda (eventmesh)
wizardzhang opened a new pull request, #4575:
URL: https://github.com/apache/eventmesh/pull/4575
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3399
### Motivation
*make code more concise*
### Modifications
*replace anonymous inner class with lambda.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3399] replace anonymous inner class with lambda (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4575:
URL: https://github.com/apache/eventmesh/pull/4575#issuecomment-1824088645
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `20 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`007553a`)](https://app.codecov.io/gh/apache/eventmesh/commit/007553a65804a53155be6254bbb5673f5b6d0bcb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 16.95% compared to head [(`5d344c6`)](https://app.codecov.io/gh/apache/eventmesh/pull/4575?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 16.93%.
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/4575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../core/protocol/tcp/client/EventMeshTcp2Client.java](https://app.codecov.io/gh/apache/eventmesh/pull/4575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9FdmVudE1lc2hUY3AyQ2xpZW50LmphdmE=) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4575 +/- ##
============================================
- Coverage 16.95% 16.93% -0.02%
Complexity 1678 1678
============================================
Files 781 781
Lines 29167 29156 -11
Branches 2511 2494 -17
============================================
- Hits 4945 4939 -6
+ Misses 23761 23757 -4
+ Partials 461 460 -1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/4575?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3399] Make this anonymous inner class a lambda[EventMeshTcp2Client] (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo merged PR #4575:
URL: https://github.com/apache/eventmesh/pull/4575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3399] replace anonymous inner class with lambda (eventmesh)
Posted by "wizardzhang (via GitHub)" <gi...@apache.org>.
wizardzhang commented on PR #4575:
URL: https://github.com/apache/eventmesh/pull/4575#issuecomment-1824138757
@xwm1992 can u review the commit for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org