You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "acelyc111 (via GitHub)" <gi...@apache.org> on 2023/09/17 16:20:31 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1611: fix(ASAN): avoid report 'odr-violation' issues
acelyc111 opened a new pull request, #1611:
URL: https://github.com/apache/incubator-pegasus/pull/1611
Now the master branch complain an ASAN issuse like:
```
==246==ERROR: AddressSanitizer: odr-violation (0x1477e70d8b40):
[1] size=1 'FLAGS_enable_http_server' /__w/incubator-pegasus/incubator-pegasus/src/http/http_server.cpp:45:1
[2] size=1 'FLAGS_enable_http_server' /__w/incubator-pegasus/incubator-pegasus/src/http/http_server.cpp:45:1
These globals were registered at these points:
[1]:
#0 0x1477eb021928 in __asan_register_globals ../../../../src/libsanitizer/asan/asan_globals.cpp:341
#1 0x1477eb9e147d (/lib64/ld-linux-x86-64.so.2+0x647d)
[2]:
#0 0x1477eb021928 in __asan_register_globals ../../../../src/libsanitizer/asan/asan_globals.cpp:341
#1 0x1477eb9e147d (/lib64/ld-linux-x86-64.so.2+0x647d)
==[24](https://github.com/apache/incubator-pegasus/actions/runs/6198033168/job/16833720760?pr=1610#step:7:25)6==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0
SUMMARY: AddressSanitizer: odr-violation: global 'FLAGS_enable_http_server' at /__w/incubator-pegasus/incubator-pegasus/src/http/http_server.cpp:45:1
==246==ABORTING
```
This patch is aim to resove the issue. See details related to the issuse:
1. https://github.com/google/sanitizers/issues/1017
2. https://github.com/google/sanitizers/wiki/AddressSanitizerOneDefinitionRuleViolation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1611: fix(ASAN): avoid reporting false 'odr-violation' issues
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #1611:
URL: https://github.com/apache/incubator-pegasus/pull/1611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org