You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org> on 2008/10/06 21:39:44 UTC
[jira] Created: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Options for a broker (given in the broker list in the connection URL) should default to the top level values
------------------------------------------------------------------------------------------------------------
Key: QPID-1319
URL: https://issues.apache.org/jira/browse/QPID-1319
Project: Qpid
Issue Type: Bug
Components: Java Client
Affects Versions: M4
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
Fix For: M4
Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
However there seems to be only one such option, which is SSL. (according to the wiki)
Ih the future there maybe more such options.
Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu resolved QPID-1319.
------------------------------------
Resolution: Fixed
The fix to the URL issues was reversed. Instead the documentation on the wiki was updated to match the code.
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu resolved QPID-1319.
------------------------------------
Resolution: Fixed
A fix for this along with a test case has been committed in r702488 on trunk.
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reopened QPID-1319:
----------------------------------
Hi Rajith, a couple of points that would be good to address in your changes.
The ssl option should only be attached to the entry in the brokerlist and not at the same level as brokerlist.
The change of the empty constructor to be totally empty highlights its weirdness, the fact that you can make the AMQBrokerDetails object in two different ways that result in two different objects
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638005#action_12638005 ]
Rajith Attapattu commented on QPID-1319:
----------------------------------------
Rob, thx for having a look at the JIRA.
The NFE was definitely a cut paste error and I will be correcting it shortly.
As for the constructor, it is been called in URLParser.java line 196.
However I think the wiki entry is wrong and I agree with Aidan that SSL should only be a broker level option.
If we go that route then you don't need this constructor.
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637932#action_12637932 ]
Rob Godfrey commented on QPID-1319:
-----------------------------------
Also, I'm not quite sure why the following constructor has been added:
public AMQBrokerDetails(String url,Map<String, String> options) throws URLSyntaxException
AFAICT at a cursory reading the only place that calls this is the other constructor which passes in "null" as the options map
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637535#action_12637535 ]
Rajith Attapattu commented on QPID-1319:
----------------------------------------
I don't believe they are problems and have answered the concerns raised by Martin.
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner reassigned QPID-1319:
-----------------------------------
Assignee: Rajith Attapattu (was: Aidan Skinner)
Assigning to Rajith since the review has found problems.
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637525#action_12637525 ]
Rajith Attapattu commented on QPID-1319:
----------------------------------------
Martin, appreciate your comments.
>The ssl option should only be attached to the entry in the brokerlist and not at the same level as brokerlist.
According to the wiki entry below that is not the case.
http://cwiki.apache.org/qpid/connection-url-format.html
More specifcally look at the following example given in the above wiki entry.
amqp://guest:guest@client/test?ssl='true'&brokerlist='tcp://localhost;tcp://redundant-server:5673?ssl='false''&failover='roundrobin'
I don't know which one is correct. What ever we do, we need to sync our documentation with the code.
> The change of the empty constructor to be totally empty highlights its weirdness, the fact that you can make the AMQBrokerDetails object in two different ways that result in two different objects
There is code in the client that does rely on the empty constructor. Look at URLParser_0_10.java line 198.
This code is not in any way weird than the previous version.
If somebody called the argumentless constructor in the previous version it would have resulted in the same state. (i.e in the prev version the options was initialized in the constructor, in the new version it was init as a field).
Could you please explain how it is different now? (maybe I have missed something).
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu updated QPID-1319:
-----------------------------------
Assignee: Aidan Skinner (was: Rajith Attapattu)
Assigning to Aidan for review as indicated on the qpid-list.
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Aidan Skinner
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642236#action_12642236 ]
Rajith Attapattu commented on QPID-1319:
----------------------------------------
The code is reversed back to what it was before the above changes were applied.
Changes are checked in r707452 on trunk.
Need to change the examples in the wiki page as well.
I also removed the NFE in the useSSL method highlighted by rob.
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642248#action_12642248 ]
Rajith Attapattu commented on QPID-1319:
----------------------------------------
I modified the examples and documentaiton on the wiki to reflect the code.
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1319) Options for a broker (given in the
broker list in the connection URL) should default to the top level values
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637930#action_12637930 ]
Rob Godfrey commented on QPID-1319:
-----------------------------------
Comment on the following snippet:
269 if (_options.containsKey(ConnectionURL.OPTIONS_SSL))
270 {
271 try
272 {
273 return Boolean.parseBoolean(_options.get(ConnectionURL.OPTIONS_SSL));
274 }
275 catch (NumberFormatException nfe)
276 {
277 //Do nothing as we will use the default below.
278 }
AFAICT there is no way that Boolean.parseBoolean can throw a NFE...
Looking at the publically available Sun 1.6 source code parseBoolean can never throw an exceptions directly...
> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-1319
> URL: https://issues.apache.org/jira/browse/QPID-1319
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.