You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/18 12:04:09 UTC

[GitHub] [spark] cloud-fan commented on pull request #29790: [SPARK-32914][SQL] Avoid calling dataType multiple times for each expression

cloud-fan commented on pull request #29790:
URL: https://github.com/apache/spark/pull/29790#issuecomment-694828526


   do we really need such an invasive change? If there is a specific expression that calls `dataType` many times, let's fix that expression only. Or if this can bring significant end-to-end perf speedup, we can consider accepting it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org