You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "ethqunzhong (via GitHub)" <gi...@apache.org> on 2023/05/21 09:13:45 UTC
[GitHub] [pulsar] ethqunzhong opened a new pull request, #20365: [fix][offload] use filesystem offloader with class not found error
ethqunzhong opened a new pull request, #20365:
URL: https://github.com/apache/pulsar/pull/20365
Fixes #16955
### Motivation
fix the problem about Failing to start standalone pulsar service with tiered storage due to class not found problem
The reason is the lack of dependencies for the `org.apache.hadoop.hdfs.DistributedFileSystem` class.
### Modifications
add DistributedFileSystem class dependency `hadoop-client` in pom.xml
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is already covered by existing tests.
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [x] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/ethqunzhong/pulsar/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #20365: [fix][offload] use filesystem offloader with class not found error
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #20365:
URL: https://github.com/apache/pulsar/pull/20365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #20365: [fix][offload] use filesystem offloader with class not found error
Posted by "ethqunzhong (via GitHub)" <gi...@apache.org>.
ethqunzhong commented on PR #20365:
URL: https://github.com/apache/pulsar/pull/20365#issuecomment-1594091647
> +1
>
> it would be great to setup an integration test one day. I assume that you tested it manually
>
> Is this problem also on Pulsar 3.0 ? should we cherry-pick this PR to branch-3.0 ?
yes. tested it manually and branch-3.0 has the same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #20365: [fix][offload] use filesystem offloader with class not found error
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #20365:
URL: https://github.com/apache/pulsar/pull/20365#issuecomment-1596358537
I see the mentioned issue #16955 with broker-2.10, so we need at least cherry-pick this to 2.10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20365: [fix][offload] use filesystem offloader with class not found error
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20365:
URL: https://github.com/apache/pulsar/pull/20365#issuecomment-1593139835
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20365](https://app.codecov.io/gh/apache/pulsar/pull/20365?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3fb0e8f) into [master](https://app.codecov.io/gh/apache/pulsar/commit/d85736cbbb6bdac8ec9f1264df479f671434350f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d85736c) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20365 +/- ##
============================================
+ Coverage 73.00% 73.07% +0.07%
- Complexity 31962 31991 +29
============================================
Files 1867 1867
Lines 138661 138661
Branches 15235 15235
============================================
+ Hits 101227 101328 +101
+ Misses 29382 29301 -81
+ Partials 8052 8032 -20
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.13% <ø> (+0.04%)` | :arrow_up: |
| systests | `24.97% <ø> (-0.08%)` | :arrow_down: |
| unittests | `72.36% <ø> (+0.08%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 65 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20365/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20365: [fix][offload] use filesystem offloader with class not found error
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20365:
URL: https://github.com/apache/pulsar/pull/20365#issuecomment-1594094348
Merging...
cc @RobertIndie I guess we can include this patch for 3.0.x on 3.0.2 at the earliest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #20365: [fix][offload] use filesystem offloader with class not found error
Posted by "ethqunzhong (via GitHub)" <gi...@apache.org>.
ethqunzhong commented on PR #20365:
URL: https://github.com/apache/pulsar/pull/20365#issuecomment-1592729255
> It seems the issued class is located at `hadoop-hdfs-client`. Could you elaborate a bit why `hadoop-client` is needed here?
@tisonkun Sorry for not timely reply. What you said is correct. After testing, simplifying the dependencies still works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #20365: [fix][offload] use filesystem offloader with class not found error
Posted by "ethqunzhong (via GitHub)" <gi...@apache.org>.
ethqunzhong commented on PR #20365:
URL: https://github.com/apache/pulsar/pull/20365#issuecomment-1559133344
@eolivelli PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org