You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 15:55:58 UTC

[PR] test: cover operator/sample sensitivity, clamps and non-ratio units in AlertRuleSemanticFingerprint [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3439:
URL: https://github.com/apache/rocketmq-dashboard/pull/3439

   ### Summary
   
   `AlertRuleSemanticFingerprint.of` hashes the evaluation semantics of a rule (domain, scope, operator, normalized threshold, duration, window, sample count). The suite covered presentation-insensitivity, scope changes and ratio-threshold normalization only.
   
   ### Changes
   
   - A different operator or a different consecutive-sample count changes the fingerprint
   - Non-positive windows and sample counts clamp to their safe defaults and stay identical to the defaults
   - The `%` threshold unit is ignored for non-ratio metrics, while the raw threshold still matters
   
   ### Testing
   
   `mvn test -Dtest=AlertRuleSemanticFingerprintTest` passes: 6 tests, 0 failures (up from 3).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: cover operator/sample sensitivity, clamps and non-ratio units in AlertRuleSemanticFingerprint [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3439: test: cover operator/sample sensitivity, clamps and non-ratio units in AlertRuleSemanticFingerprint
URL: https://github.com/apache/rocketmq-dashboard/pull/3439


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org