[jira] [Commented] (HDFS-8409) HDFS client RPC call throws "java.lang.IllegalStateException"

["Andrew Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-8409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568011#comment-14568011 ] 

Andrew Wang commented on HDFS-8409:
-----------------------------------

I guess I'm confused where these exceptions are coming from. This error happens if we call {{setCallIdAndRetryCount}} twice without an intervening creation of a {{Call}}. This means an exception somewhere in {{invokeMethod}} before the {{Call}} is created. I looked at {{ProtobufRpcEngine#invoke}} and I don't see any non-fatal exceptions that would be fixed by a retry. Am I off-base here?

Do you have more logging from when this happened?

> HDFS client RPC call throws "java.lang.IllegalStateException"
> -------------------------------------------------------------
>
>                 Key: HDFS-8409
>                 URL: https://issues.apache.org/jira/browse/HDFS-8409
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>            Reporter: Juan Yu
>            Assignee: Juan Yu
>         Attachments: HDFS-8409.001.patch, HDFS-8409.002.patch, HDFS-8409.003.patch
>
>
> When the HDFS client RPC calls need to retry, it sometimes throws "java.lang.IllegalStateException" and retry is aborted and cause the client call will fail.
> {code}
> Caused by: java.lang.IllegalStateException
> 	at com.google.common.base.Preconditions.checkState(Preconditions.java:129)
> 	at org.apache.hadoop.ipc.Client.setCallIdAndRetryCount(Client.java:116)
> 	at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:99)
> 	at com.sun.proxy.$Proxy16.getFileInfo(Unknown Source)
> 	at org.apache.hadoop.hdfs.DFSClient.getFileInfo(DFSClient.java:1912)
> 	at org.apache.hadoop.hdfs.DistributedFileSystem$17.doCall(DistributedFileSystem.java:1089)
> 	at org.apache.hadoop.hdfs.DistributedFileSystem$17.doCall(DistributedFileSystem.java:1085)
> 	at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
> 	at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1085)
> 	at org.apache.hadoop.fs.FileSystem.exists(FileSystem.java:1400)
> {code}
> Here is the check that throws exception
> {code}
>   public static void setCallIdAndRetryCount(int cid, int rc) {
>       ...
>       Preconditions.checkState(callId.get() == null);
>   }
> {code}
> The RetryInvocationHandler tries to call it with not null callId and causes exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)