You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/08 12:00:59 UTC

[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.

Ted-Jiang commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1016530063


##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -40,7 +40,7 @@ use crate::file::serialized_reader::ReadOptionsBuilder;
 use crate::schema::types::SchemaDescriptor;
 
 mod filter;
-mod selection;
+pub mod selection;

Review Comment:
   because 
   ```
   function `intersect_row_selection` is never used
   
   ```
   I make this mod pub, i think this is ok🤔



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org