You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/11 23:59:09 UTC

[GitHub] [geode] upthewaterspout commented on a change in pull request #6123: GEODE-9019: Fixed missing synchronization blocks

upthewaterspout commented on a change in pull request #6123:
URL: https://github.com/apache/geode/pull/6123#discussion_r592815012



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/data/RedisString.java
##########
@@ -615,7 +615,7 @@ public int setbit(
    */
 
   @Override
-  public void toData(DataOutput out, SerializationContext context) throws IOException {
+  public synchronized void toData(DataOutput out, SerializationContext context) throws IOException {

Review comment:
       I don't think it's just toData in for RedisString, I believe other methods need to be synchronized as well (like RedisHash and RedisSet do). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org