[GitHub] vylc commented on issue #6565: SQL Lab SQL Editor Resizer UI Improvement

[GitBox <gi...@apache.org>]

vylc commented on issue #6565: SQL Lab SQL Editor Resizer UI Improvement
URL: https://github.com/apache/incubator-superset/issues/6565#issuecomment-449522199
 
 
   @thinmatt can we put some thought into where those buttons should be placed if within the SQL editor panel? ie. usually action buttons are in the lower right. also, SQL queries tend to be more vertical than wide, so gives more usable real estate for the SQL query. thoughts on why parameters is over there vs. with the other ones?
   i'm not sure how i feel about the buttons being in the editor itself, but i think it's because it's something i'm not used to. not against, but may take some time to sink in

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org