[jira] [Commented] (SAMZA-340) Support metrics report via Graphite

["Luis De Pombo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570049#comment-14570049 ] 

Luis De Pombo commented on SAMZA-340:
-------------------------------------

[~closeuris] I got around the getMax() error by changing the interface the Timer and Snapshot interfaces. Nevertheless, I suspect the issue lies in SlidingTimeWindowReservoir.getSnapshot() which returns a mutable Snapshot that will continue to be updated throughout reports to the given Timer.

In other words, the code for the reservoir currently looks like this:
{code}
  public Snapshot getSnapshot() {
    removeExpireValues();
    return new Snapshot(Collections.unmodifiableCollection(storage.values()));
  }
{code}

And we should instead be returning an immutable collection:
{code}
  @Override
  public Snapshot getSnapshot() {
    removeExpireValues();
    return new Snapshot(Collections.unmodifiableCollection(storage.values()));
  }
{code}

I also made 2003 the default graphite port and updated the configuration-table to include metrics.reporter.reporter-name.host, metrics.reporter.reporter-name.port and metrics.reporter.reporter-name.report.period.sec as you suggested. 

Also addressed comments in metrics documentation pointed out by [~cpsoman]. This diff is now ready.

> Support metrics report via Graphite
> -----------------------------------
>
>                 Key: SAMZA-340
>                 URL: https://issues.apache.org/jira/browse/SAMZA-340
>             Project: Samza
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.9.0
>            Reporter: Yan Fang
>            Assignee: Luis De Pombo
>              Labels: metrics
>         Attachments: SAMZA-340.patch, SAMZA-340.v2.patch
>
>
> Currently we only support metrics report via JMX, it is helpful to support more output formats.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)