You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by rmannibucau <gi...@git.apache.org> on 2018/01/09 11:00:54 UTC
[GitHub] logging-log4j2 pull request #140: adding log4j2.forceTCLOnly option
GitHub user rmannibucau opened a pull request:
https://github.com/apache/logging-log4j2/pull/140
adding log4j2.forceTCLOnly option
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmannibucau/logging-log4j2 fix/LOG4J2-2171_dont-assume-systemclassloader-should-be-used
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #140
----
commit 2be941eba13dc6a8af0c0a452a4624295c88b553
Author: Romain Manni-Bucau <rm...@...>
Date: 2018-01-09T10:59:52Z
adding log4j2.forceTCLOnly option
----
---
[GitHub] logging-log4j2 issue #140: adding log4j2.forceTCLOnly option
Posted by jvz <gi...@git.apache.org>.
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/140
Changes look pretty good. Could you rebase from master?
It would also be great if you could add a Jira issue for this so we can include this in the changelog. Thanks!
---
[GitHub] logging-log4j2 pull request #140: [LOG4J2-2171] adding log4j2.forceTCLOnly o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/logging-log4j2/pull/140
---
[GitHub] logging-log4j2 issue #140: [LOG4J2-2171] adding log4j2.forceTCLOnly option
Posted by rmannibucau <gi...@git.apache.org>.
Github user rmannibucau commented on the issue:
https://github.com/apache/logging-log4j2/pull/140
@jvz done :)
---
[GitHub] logging-log4j2 issue #140: [LOG4J2-2171] adding log4j2.forceTCLOnly option
Posted by jvz <gi...@git.apache.org>.
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/140
And could you re-add the docs? I just converted the page to asciidoc yesterday, so you'll have to check a different file: `src/site/asciidoc/manual/configuration.adoc`
---
[GitHub] logging-log4j2 issue #140: [LOG4J2-2171] adding log4j2.forceTCLOnly option
Posted by rmannibucau <gi...@git.apache.org>.
Github user rmannibucau commented on the issue:
https://github.com/apache/logging-log4j2/pull/140
Oh missed that, done
---