You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/03/30 23:45:46 UTC
[PR] [SPARK-56298] Enable `spark.master.rest.virtualThread.enabled` by default [spark]
dongjoon-hyun opened a new pull request, #55102:
URL: https://github.com/apache/spark/pull/55102
### What changes were proposed in this pull request?
This PR changes the default value of `spark.master.rest.virtualThread.enabled` from `false` to `true`.
### Why are the changes needed?
The runtime guard (`Utils.isJavaVersionAtLeast21`) already exists in `RestSubmissionServer`, so enabling this by default is safe:
- On Java 17: no behavior change (virtual threads are not activated)
- On Java 21+: virtual threads are automatically used for the Master REST API, improving scalability
### Does this PR introduce _any_ user-facing change?
Yes. On Java 21+, the Spark Master REST API server now uses virtual threads by default. To restore the previous behavior, set `spark.master.rest.virtualThread.enabled` to `false`.
### How was this patch tested?
Pass the existing tests.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.6 with 1M context)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56298] Enable `spark.master.rest.virtualThread.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55102:
URL: https://github.com/apache/spark/pull/55102#issuecomment-4160507477
Thank you, @peter-toth .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56298] Enable `spark.master.rest.virtualThread.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55102:
URL: https://github.com/apache/spark/pull/55102#issuecomment-4159622703
All tests passed. Could you review this PR, @LuciferYang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56298] Enable `spark.master.rest.virtualThread.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #55102: [SPARK-56298] Enable `spark.master.rest.virtualThread.enabled` by default
URL: https://github.com/apache/spark/pull/55102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56298] Enable `spark.master.rest.virtualThread.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55102:
URL: https://github.com/apache/spark/pull/55102#issuecomment-4158855856
cc @peter-toth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56298] Enable `spark.master.rest.virtualThread.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55102:
URL: https://github.com/apache/spark/pull/55102#issuecomment-4159636551
Thank you so much! Merged to master for Apache Spark 4.2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org