[GitHub] [jackrabbit-oak] kwin commented on a change in pull request #288: OAK-9415 expose attached principals in JackrabbitSession

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #288:
URL: https://github.com/apache/jackrabbit-oak/pull/288#discussion_r617432006



##########
File path: oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/JackrabbitSession.java
##########
@@ -23,15 +23,21 @@
 import javax.jcr.Node;
 import javax.jcr.Property;
 import javax.jcr.Session;
+
+import java.security.Principal;
+import java.util.Set;
+
 import javax.jcr.AccessDeniedException;
 import javax.jcr.RepositoryException;
 import javax.jcr.UnsupportedRepositoryOperationException;
 
 import org.jetbrains.annotations.NotNull;
+import org.osgi.annotation.versioning.ProviderType;
 
 /**
  * Jackrabbit specific extension of the JCR {@link javax.jcr.Session} interface.
  */
+@ProviderType

Review comment:
       This was not marked as provider type before. The default is consumer type which requires a major version change for each added method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org