You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jared Stewart <js...@pivotal.io> on 2017/08/23 20:18:26 UTC
Review Request 61860: GEODE-3510: GfshRule displays output from
StdError
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61860/
-----------------------------------------------------------
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-3510: GfshRule displays output from StdError
Diffs
-----
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java 47f030471a988055400a71e5b564f3b24397c2e8
Diff: https://reviews.apache.org/r/61860/diff/1/
Testing
-------
Precheckin running
Thanks,
Jared Stewart
Re: Review Request 61860: GEODE-3510: GfshRule displays output from
StdError
Posted by Jared Stewart <js...@pivotal.io>.
> On Aug. 24, 2017, 9:29 p.m., Kirk Lund wrote:
> > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
> > Lines 96 (patched)
> > <https://reviews.apache.org/r/61860/diff/1/?file=1802513#file1802513line96>
> >
> > I'm curious, what's the result of this method? Does in interleave stdout and stderr in someway?
> >
> > Another alternative is to use ProcessBuilder.redirectErrorStream so they become interleaved chronologically. The downside is you can't differentiate between the two. But there's probably some other way to synchronize the two chronologically using a stream tee or union.
I'll remove this method for now until I have a better implementation.
- Jared
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61860/#review183798
-----------------------------------------------------------
On Aug. 23, 2017, 8:18 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61860/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2017, 8:18 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3510: GfshRule displays output from StdError
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java 47f030471a988055400a71e5b564f3b24397c2e8
>
>
> Diff: https://reviews.apache.org/r/61860/diff/1/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 61860: GEODE-3510: GfshRule displays output from
StdError
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61860/#review183798
-----------------------------------------------------------
Ship it!
Ship It!
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
Lines 96 (patched)
<https://reviews.apache.org/r/61860/#comment259846>
I'm curious, what's the result of this method? Does in interleave stdout and stderr in someway?
Another alternative is to use ProcessBuilder.redirectErrorStream so they become interleaved chronologically. The downside is you can't differentiate between the two. But there's probably some other way to synchronize the two chronologically using a stream tee or union.
- Kirk Lund
On Aug. 23, 2017, 8:18 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61860/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2017, 8:18 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3510: GfshRule displays output from StdError
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java 47f030471a988055400a71e5b564f3b24397c2e8
>
>
> Diff: https://reviews.apache.org/r/61860/diff/1/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 61860: GEODE-3510: GfshRule displays output from
StdError
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61860/
-----------------------------------------------------------
(Updated Aug. 25, 2017, 9:12 p.m.)
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Changes
-------
Remove getAllOutputLines() and remove an unused file.
Repository: geode
Description
-------
GEODE-3510: GfshRule displays output from StdError
Diffs (updated)
-----
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java 47f0304
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsAbstractFunction.java cf7c7a2
Diff: https://reviews.apache.org/r/61860/diff/2/
Changes: https://reviews.apache.org/r/61860/diff/1-2/
Testing
-------
Precheckin running
Thanks,
Jared Stewart
Re: Review Request 61860: GEODE-3510: GfshRule displays output from
StdError
Posted by Patrick Rhomberg <pr...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61860/#review183747
-----------------------------------------------------------
Ship it!
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
Lines 24 (patched)
<https://reviews.apache.org/r/61860/#comment259801>
Left a straggler.
- Patrick Rhomberg
On Aug. 23, 2017, 8:18 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61860/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2017, 8:18 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3510: GfshRule displays output from StdError
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java 47f030471a988055400a71e5b564f3b24397c2e8
>
>
> Diff: https://reviews.apache.org/r/61860/diff/1/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>