You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by denalex <gi...@git.apache.org> on 2016/10/12 20:54:49 UTC
[GitHub] incubator-hawq pull request #957: HAWQ-963. PXF support for IS_NULL and IS_N...
GitHub user denalex opened a pull request:
https://github.com/apache/incubator-hawq/pull/957
HAWQ-963. PXF support for IS_NULL and IS_NOT_NULL conditions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/denalex/incubator-hawq alex-HAWQ-963
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/957.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #957
----
commit 3f7894df71d0c8f4bf086d747b33073e00daa50d
Author: Alexander Denissov <ad...@pivotal.io>
Date: 2016-10-12T20:46:33Z
HAWQ-963. PXF support for IS_NULL and IS_NOT_NULL conditions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #957: HAWQ-963. PXF support for IS_NULL and IS_N...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/957#discussion_r83110772
--- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java ---
@@ -63,7 +63,9 @@
HDOP_EQ,
HDOP_NE,
HDOP_AND,
- HDOP_LIKE
+ HDOP_LIKE,
+ HDOP_ISNULL,
--- End diff --
Make them HDOP_IS_NULL, HDOP_IS_NOT_NULL?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #957: HAWQ-963. PXF support for IS_NULL and IS_N...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/957
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #957: HAWQ-963. PXF support for IS_NULL and IS_N...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/957#discussion_r83111298
--- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java ---
@@ -63,7 +63,9 @@
HDOP_EQ,
HDOP_NE,
HDOP_AND,
- HDOP_LIKE
+ HDOP_LIKE,
--- End diff --
Does it makes sense to separate UnaryOperation to new enum?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #957: HAWQ-963. PXF support for IS_NULL and IS_N...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/957#discussion_r83262359
--- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java ---
@@ -63,7 +63,9 @@
HDOP_EQ,
HDOP_NE,
HDOP_AND,
- HDOP_LIKE
+ HDOP_LIKE,
--- End diff --
I don't think we need a separate enum for unary operator. We have separate enums currently based on how HAWQ bridge separates a/c/o operators. Also we will soon introduce IN and other operators as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---