You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Alex Herbert (Jira)" <ji...@apache.org> on 2021/06/24 11:36:00 UTC

[jira] [Created] (RNG-146) GaussianSampler should not allow infinite standard deviation

Alex Herbert created RNG-146:
--------------------------------

             Summary: GaussianSampler should not allow infinite standard deviation
                 Key: RNG-146
                 URL: https://issues.apache.org/jira/browse/RNG-146
             Project: Commons RNG
          Issue Type: Bug
          Components: sampling
    Affects Versions: 1.3
            Reporter: Alex Herbert


The GaussianSampler requires the standard deviation is strictly positive. It allows an infinite value. This will produce a NaN output if the NormalizedGaussianSampler returns 0:
{code:java}
@Test
public void testInfiniteStdDev() {
    NormalizedGaussianSampler gauss = new NormalizedGaussianSampler() {
        @Override
        public double sample() {
            return 0;
        }
    };
    GaussianSampler s = new GaussianSampler(gauss, 0, Double.POSITIVE_INFINITY);
    Assert.assertEquals(Double.NaN, s.sample(), 0.0);
}
{code}

A fix is to require the standard deviation is finite.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)