You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/28 14:19:53 UTC

[GitHub] [arrow] rok opened a new pull request, #13024: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels follow-up

rok opened a new pull request, #13024:
URL: https://github.com/apache/arrow/pull/13024

   This is to follow-up #12997 and resolve [ARROW-16173](https://issues.apache.org/jira/browse/ARROW-16173).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] amol- commented on pull request #13024: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels follow-up

Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- commented on PR #13024:
URL: https://github.com/apache/arrow/pull/13024#issuecomment-1490654763

   Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #13024: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels follow-up

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13024:
URL: https://github.com/apache/arrow/pull/13024#issuecomment-1112266903

   https://issues.apache.org/jira/browse/ARROW-16173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] rok commented on pull request #13024: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels follow-up

Posted by GitBox <gi...@apache.org>.
rok commented on PR #13024:
URL: https://github.com/apache/arrow/pull/13024#issuecomment-1112325567

   @ursabot please benchmark command=cpp-micro --suite-filter=scalar-temporal


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] rok commented on pull request #13024: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels follow-up

Posted by GitBox <gi...@apache.org>.
rok commented on PR #13024:
URL: https://github.com/apache/arrow/pull/13024#issuecomment-1112571740

   It seems like the problem is present here as well. Please don't merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] rok commented on pull request #13024: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels follow-up

Posted by GitBox <gi...@apache.org>.
rok commented on PR #13024:
URL: https://github.com/apache/arrow/pull/13024#issuecomment-1112372436

   I am getting segfaults when running benchmarks locally. It seems to be related to the null proportions. I'm still exploring.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] amol- closed pull request #13024: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels follow-up

Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- closed pull request #13024: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels follow-up
URL: https://github.com/apache/arrow/pull/13024


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #13024: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels follow-up

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13024:
URL: https://github.com/apache/arrow/pull/13024#issuecomment-1112339864

   Can you describe the change in the PR text?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #13024: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels follow-up

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13024:
URL: https://github.com/apache/arrow/pull/13024#issuecomment-1112325659

   Benchmark runs are scheduled for baseline = a713e7fa5dbd4997cfdac928cf868f38c31ac3d0 and contender = 4b456b1d57dbfa38aef28b6e049468b88cf629d9. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Only ['lang', 'name'] filters are supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e8dc177b5c8f45918a6f22403d2750ea...261933ff38ac48e5bb47ea4262477081/)
   [Skipped :warning: Only ['lang', 'name'] filters are supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/54e1d50a715e48b791f5ffbee3e5211f...0139fcc4953947c78f3edda23781755e/)
   [Skipped :warning: Only ['lang', 'name'] filters are supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/be3e6dd21c1441b4b01e563b428e6735...5dfefc2a72714b16979f83020cc3097d/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9ae98140bb104c8896257d3d5967671e...03d96b088ffd47c183390dbe145db4fe/)
   Buildkite builds:
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/645| `4b456b1d` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/661| `a713e7fa` ec2-t3-xlarge-us-east-2>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/652| `a713e7fa` test-mac-arm>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/599| `a713e7fa` ursa-i9-9960x>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/644| `a713e7fa` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org