You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/16 08:13:56 UTC

[GitHub] [shardingsphere] jiangML opened a new pull request, #23578: Oprimize agent metrics

jiangML opened a new pull request, #23578:
URL: https://github.com/apache/shardingsphere/pull/23578

   Fixes #23577.
   
   Changes proposed in this pull request:
     - Optimize proxy_state to remove name label.
     - Refactor TimeRecorder
     - Update agent doc
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #23578: Oprimize agent metrics

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23578:
URL: https://github.com/apache/shardingsphere/pull/23578#issuecomment-1383690941

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23578](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85863c7) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c182a11758b178304481b53309e0a8756f506735?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c182a11) will **increase** coverage by `0.00%`.
   > The diff coverage is `73.17%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #23578   +/-   ##
   =========================================
     Coverage     49.77%   49.78%           
     Complexity     2507     2507           
   =========================================
     Files          4114     4116    +2     
     Lines         58490    58506   +16     
     Branches      10131    10132    +1     
   =========================================
   + Hits          29112    29125   +13     
   - Misses        26862    26866    +4     
   + Partials       2516     2515    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...nt/plugin/core/recorder/AdviceRecordPointMark.java](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vY29yZS9yZWNvcmRlci9BZHZpY2VSZWNvcmRQb2ludE1hcmsuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...re/agent/plugin/core/recorder/RecordPointMark.java](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vY29yZS9yZWNvcmRlci9SZWNvcmRQb2ludE1hcmsuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/file/advice/MetaDataContextsFactoryAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9sb2dnaW5nL3R5cGUvZmlsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL2xvZ2dpbmcvZmlsZS9hZHZpY2UvTWV0YURhdGFDb250ZXh0c0ZhY3RvcnlBZHZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...resource/RegisterStorageUnitStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9pdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3QvaXQvc3FsL3BhcnNlci9pbnRlcm5hbC9jYXNlcy9wYXJzZXIvamF4Yi9zdGF0ZW1lbnQvcmRsL3Jlc291cmNlL1JlZ2lzdGVyU3RvcmFnZVVuaXRTdGF0ZW1lbnRUZXN0Q2FzZS5qYXZh) | `100.00% <ø> (ø)` | |
   | [...abaseDiscoveryDefinitionRuleStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9pdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3QvaXQvc3FsL3BhcnNlci9pbnRlcm5hbC9jYXNlcy9wYXJzZXIvamF4Yi9zdGF0ZW1lbnQvcmRsL3J1bGUvZGJkaXNjb3ZlcnkvQ3JlYXRlRGF0YWJhc2VEaXNjb3ZlcnlEZWZpbml0aW9uUnVsZVN0YXRlbWVudFRlc3RDYXNlLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...le/encrypt/CreateEncryptRuleStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9pdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3QvaXQvc3FsL3BhcnNlci9pbnRlcm5hbC9jYXNlcy9wYXJzZXIvamF4Yi9zdGF0ZW1lbnQvcmRsL3J1bGUvZW5jcnlwdC9DcmVhdGVFbmNyeXB0UnVsZVN0YXRlbWVudFRlc3RDYXNlLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...rdl/rule/mask/CreateMaskRuleStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9pdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3QvaXQvc3FsL3BhcnNlci9pbnRlcm5hbC9jYXNlcy9wYXJzZXIvamF4Yi9zdGF0ZW1lbnQvcmRsL3J1bGUvbWFzay9DcmVhdGVNYXNrUnVsZVN0YXRlbWVudFRlc3RDYXNlLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...CreateReadwriteSplittingRuleStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9pdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3QvaXQvc3FsL3BhcnNlci9pbnRlcm5hbC9jYXNlcy9wYXJzZXIvamF4Yi9zdGF0ZW1lbnQvcmRsL3J1bGUvcmVhZHdyaXRlc3BsaXR0aW5nL0NyZWF0ZVJlYWR3cml0ZVNwbGl0dGluZ1J1bGVTdGF0ZW1lbnRUZXN0Q2FzZS5qYXZh) | `100.00% <ø> (ø)` | |
   | [...CreateDefaultShadowAlgorithmStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9pdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3QvaXQvc3FsL3BhcnNlci9pbnRlcm5hbC9jYXNlcy9wYXJzZXIvamF4Yi9zdGF0ZW1lbnQvcmRsL3J1bGUvc2hhZG93L0NyZWF0ZURlZmF1bHRTaGFkb3dBbGdvcml0aG1TdGF0ZW1lbnRUZXN0Q2FzZS5qYXZh) | `100.00% <ø> (ø)` | |
   | [...rule/shadow/CreateShadowRuleStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9pdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3QvaXQvc3FsL3BhcnNlci9pbnRlcm5hbC9jYXNlcy9wYXJzZXIvamF4Yi9zdGF0ZW1lbnQvcmRsL3J1bGUvc2hhZG93L0NyZWF0ZVNoYWRvd1J1bGVTdGF0ZW1lbnRUZXN0Q2FzZS5qYXZh) | `100.00% <ø> (ø)` | |
   | ... and [22 more](https://codecov.io/gh/apache/shardingsphere/pull/23578?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu merged pull request #23578: Optimize agent metrics

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #23578:
URL: https://github.com/apache/shardingsphere/pull/23578


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org