You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Tomasz Janiszewski <ja...@gmail.com> on 2019/07/24 17:19:04 UTC
Review Request 71157: Update docker image before build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71157/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-9906
https://issues.apache.org/jira/browse/MESOS-9906
Repository: mesos
Description
-------
We need to run `docker pull` before `docker run` to endusre build is done against latest docker image.
Diffs
-----
support/mesos-build.sh ee8ef8b8cfa84067fd7067dd8bf7dbde1cc7e67e
Diff: https://reviews.apache.org/r/71157/diff/1/
Testing
-------
Thanks,
Tomasz Janiszewski
Re: Review Request 71157: Update docker image before build.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71157/#review216835
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71157]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 24, 2019, 5:19 p.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71157/
> -----------------------------------------------------------
>
> (Updated July 24, 2019, 5:19 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9906
> https://issues.apache.org/jira/browse/MESOS-9906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We need to run `docker pull` before `docker run` to endusre build is done against latest docker image.
>
>
> Diffs
> -----
>
> support/mesos-build.sh ee8ef8b8cfa84067fd7067dd8bf7dbde1cc7e67e
>
>
> Diff: https://reviews.apache.org/r/71157/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 71157: Update docker image before build.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71157/#review216847
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On July 24, 2019, 7:19 p.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71157/
> -----------------------------------------------------------
>
> (Updated July 24, 2019, 7:19 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9906
> https://issues.apache.org/jira/browse/MESOS-9906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We need to run `docker pull` before `docker run` to endusre build is done against latest docker image.
>
>
> Diffs
> -----
>
> support/mesos-build.sh ee8ef8b8cfa84067fd7067dd8bf7dbde1cc7e67e
>
>
> Diff: https://reviews.apache.org/r/71157/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>