You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/07/17 02:51:54 UTC
[Impala-ASF-CR](asf-site) Update download page to use Apache mirror system
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17693
Change subject: Update download page to use Apache mirror system
......................................................................
Update download page to use Apache mirror system
Download links of artifacts should not link directly to the ASF host,
i.e. downloads.apache.org. Instead, we should use a link to the Apache
mirror system. So users can be redirected to the best mirror.
This patch also update links to archive.apache.org to use https.
Reference:
https://infra.apache.org/release-download-pages.html
Tests:
- Check links manually of the download page.
Change-Id: I2ff02516b27dc186c89869ab99ca8e020ae224c6
---
M downloads.html
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/17693/1
--
To view, visit http://gerrit.cloudera.org:8080/17693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ff02516b27dc186c89869ab99ca8e020ae224c6
Gerrit-Change-Number: 17693
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR](asf-site) Update download page to use Apache mirror system
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17693 )
Change subject: Update download page to use Apache mirror system
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff02516b27dc186c89869ab99ca8e020ae224c6
Gerrit-Change-Number: 17693
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 17 Jul 2021 07:55:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Update download page to use Apache mirror system
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17693 )
Change subject: Update download page to use Apache mirror system
......................................................................
Update download page to use Apache mirror system
Download links of artifacts should not link directly to the ASF host,
i.e. downloads.apache.org. Instead, we should use a link to the Apache
mirror system. So users can be redirected to the best mirror.
This patch also update links to archive.apache.org to use https.
Reference:
https://infra.apache.org/release-download-pages.html
Tests:
- Check links manually of the download page.
Change-Id: I2ff02516b27dc186c89869ab99ca8e020ae224c6
Reviewed-on: http://gerrit.cloudera.org:8080/17693
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M downloads.html
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Quanlong Huang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ff02516b27dc186c89869ab99ca8e020ae224c6
Gerrit-Change-Number: 17693
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR](asf-site) Update download page to use Apache mirror system
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17693 )
Change subject: Update download page to use Apache mirror system
......................................................................
Patch Set 1:
Thank Joe! Merging this.
--
To view, visit http://gerrit.cloudera.org:8080/17693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff02516b27dc186c89869ab99ca8e020ae224c6
Gerrit-Change-Number: 17693
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 17 Jul 2021 07:55:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Update download page to use Apache mirror system
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17693 )
Change subject: Update download page to use Apache mirror system
......................................................................
Patch Set 1: Code-Review+2
This looks good to me. I tried the links and compared to the guidance on https://infra.apache.org/release-download-pages.html
--
To view, visit http://gerrit.cloudera.org:8080/17693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff02516b27dc186c89869ab99ca8e020ae224c6
Gerrit-Change-Number: 17693
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Jul 2021 03:15:14 +0000
Gerrit-HasComments: No